- Notifications
You must be signed in to change notification settings - Fork10.5k
[release/8.0] Improve usage ofType.GetType when activating types in data protection#54762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ateInstance<IXmlDecryptor>
…taProtection.Tests/XmlEncryption/XmlEncryptionExtensionsTests.cs
amcasey approved these changesMar 26, 2024
oskogstad referenced this pull request in Altinn/dialogportenMay 26, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [Microsoft.AspNetCore.Authentication.JwtBearer](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.AspNetCore.OpenApi](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)||[Microsoft.EntityFrameworkCore.Relational](https://docs.microsoft.com/ef/core/)([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)||[Microsoft.EntityFrameworkCore.Tools](https://docs.microsoft.com/ef/core/)([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.Extensions.Caching.StackExchangeRedis](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.Extensions.Http.Polly](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>dotnet/aspnetcore(Microsoft.AspNetCore.Authentication.JwtBearer)</summary>###[`v8.0.5`](https://togithub.com/dotnet/aspnetcore/releases/tag/v8.0.5):.NET 8.0.5[Release](https://togithub.com/dotnet/core/releases/tag/v8.0.5)##### What's Changed- \[release/8.0] Update dependencies from dotnet/source-build-externalsby [@​dotnet-maestro](https://togithub.com/dotnet-maestro) in[https://github.com/dotnet/aspnetcore/pull/54744](https://togithub.com/dotnet/aspnetcore/pull/54744)- Update branding to 8.0.5 by[@​vseanreesermsft](https://togithub.com/vseanreesermsft) in[https://github.com/dotnet/aspnetcore/pull/54907](https://togithub.com/dotnet/aspnetcore/pull/54907)- \[release/8.0] Convert to 1ES templates by[@​RussKie](https://togithub.com/RussKie) in[https://github.com/dotnet/aspnetcore/pull/54660](https://togithub.com/dotnet/aspnetcore/pull/54660)- Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton by[@​Eilon](https://togithub.com/Eilon) in[https://github.com/dotnet/aspnetcore/pull/54608](https://togithub.com/dotnet/aspnetcore/pull/54608)- \[release/8.0] (deps): Bump src/submodules/googletest from `31993df`to `77afe8e` by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/dotnet/aspnetcore/pull/54872](https://togithub.com/dotnet/aspnetcore/pull/54872)- \[release/8.0] Reduce helix-matrix timeout to 5 hours by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/54778](https://togithub.com/dotnet/aspnetcore/pull/54778)- \[release/8.0] Preserve RemoteAuthenticationContext during trimming ifused in JS interop by [@​halter73](https://togithub.com/halter73)in[https://github.com/dotnet/aspnetcore/pull/54655](https://togithub.com/dotnet/aspnetcore/pull/54655)- \[release/8.0] Improve usage of `Type.GetType` when activating typesin data protection by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/54762](https://togithub.com/dotnet/aspnetcore/pull/54762)- \[release/8.0] Fix route analyzer performance with highly concatenatedstrings by [@​github-actions](https://togithub.com/github-actions)in[https://github.com/dotnet/aspnetcore/pull/54763](https://togithub.com/dotnet/aspnetcore/pull/54763)- \[release/8.0] Suppress .ps1 SDL errors by[@​wtgodbe](https://togithub.com/wtgodbe) in[https://github.com/dotnet/aspnetcore/pull/54915](https://togithub.com/dotnet/aspnetcore/pull/54915)- \[release/8.0] Backport test fixes by[@​MackinnonBuck](https://togithub.com/MackinnonBuck) in[https://github.com/dotnet/aspnetcore/pull/54912](https://togithub.com/dotnet/aspnetcore/pull/54912)- \[release/8.0] Skip SpotBugs for now by[@​wtgodbe](https://togithub.com/wtgodbe) in[https://github.com/dotnet/aspnetcore/pull/54952](https://togithub.com/dotnet/aspnetcore/pull/54952)- Merging internal commits for release/8.0 by[@​vseanreesermsft](https://togithub.com/vseanreesermsft) in[https://github.com/dotnet/aspnetcore/pull/55034](https://togithub.com/dotnet/aspnetcore/pull/55034)- \[release/8.0] Update dependencies from dotnet/arcade by[@​dotnet-maestro](https://togithub.com/dotnet-maestro) in[https://github.com/dotnet/aspnetcore/pull/55061](https://togithub.com/dotnet/aspnetcore/pull/55061)- \[release/8.0] Update Wix version by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/55101](https://togithub.com/dotnet/aspnetcore/pull/55101)**Full Changelog**:dotnet/aspnetcore@v8.0.4...v8.0.5</details><details><summary>dotnet/efcore(Microsoft.EntityFrameworkCore.Relational)</summary>### [`v8.0.5`](https://togithub.com/dotnet/efcore/releases/tag/v8.0.5):EF Core 8.0.5This is a [patch release of EF Core8.0](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/8.0.5)containing only updates to dependencies. There are no additional fixesin this release beyond those already shipped in EF Core 8.0.4.</details>---### Configuration📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am onWednesday" (UTC), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/digdir/dialogporten).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->---------Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
This was referencedJul 22, 2025
Closed
Open
This was referencedNov 12, 2025
Open
Open
Open
This was referencedNov 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#54256 to release/8.0
/cc@JamesNK@khellang
Improve usage of
Type.GetTypewhen activating types in data protectionMicrosoft.AspNetCore.DataProtection was changed in .NET 8 to support AOT. One of the changes caused
Type.GetType(typeName, throwOnError)to be called earlier than it was in .NET 7 in earlier. In rare circumstances this causes a regression and an error to be thrown.The error occurs if an app is using a custom data protection decryptor, such as
Azure.Extensions.AspNetCore.DataProtection.Keysfrom Azure, and the app is on .NET Framework (the data protection supports .NET Framework targets). Even thoughthrowOnErroris false in the call toType.GetType, .NET Framework strong name binding can still cause the method to fail with an error.The fix is to:
Type.GetType. An error is treated the same as failing to resolve the type. This makesType.GetTypebehavior consistent between .NET 5+ and .NET FrameworkType.GetType. This is a performance optimization to reduce the need to callType.GetType. We don't want .NET Framework to throw excessive internal exceptions and hurt performance.Fixes#54253
Fixes#48910
Customer Impact
Microsoft.AspNetCore.DataProtection package 8.0.x can't be used with custom encryptors/decryptors on .NET Framework.
Regression?
This scenario worked without error with
Microsoft.AspNetCore.DataProtectionpackage 7.0.x and earlier.Risk
Minor changes to the
Microsoft.AspNetCore.DataProtectionlibrary.Verification
Before (error):
After (success):
Packaging changes reviewed?
When servicing release/2.1