- Notifications
You must be signed in to change notification settings - Fork10.5k
Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton#54608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Eilon commentedMar 19, 2024
| Console.WriteLine($"Current directory:{Environment.CurrentDirectory}"); | ||
| Console.WriteLine($"Current assembly:{typeof(Program).Assembly.Location}"); | ||
| Console.WriteLine($"[{DateTime.Now.ToLongTimeString()}]Current directory:{Environment.CurrentDirectory}"); |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All these DateTime.Now's are so that eachline within the log has the actual time it was generated. Otherwise all the lines get written out to the xUnit log at the same time and thus all have the same timestamp, which isn't useful if you're trying to see how long it took between lines.
Eilon commentedMar 19, 2024
| constintMaxWaitTimes=30; | ||
| constintWaitTimeInMS=250; | ||
| constintWaitTimeInMS=1000; |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Increase delay time for this retry to hopefully help improve success rate.
Eilon commentedMar 19, 2024
| awaitphotinoProcess.WaitForExitAsync().TimeoutAfter(TimeSpan.FromSeconds(30)); | ||
| awaitphotinoProcess.WaitForExitAsync().TimeoutAfter(TimeSpan.FromSeconds(60)); | ||
| output.WriteLine(testProgramOutput); |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Always log the test output even on successful runs to help compare successful runs to failed runs (in case it turns out to be a machine slowness issue).
ContributorAuthor
Eilon commentedMar 19, 2024
/azp run |
| Azure Pipelines successfully started running 3 pipeline(s). |
mkArtakMSFT approved these changesMar 20, 2024
Contributor
mkArtakMSFT commentedMar 20, 2024
@wtgodbe can you please merge this test-only change? |
Member
wtgodbe commentedMar 20, 2024
Branches are closed now, we have to wait until they open at the beginning of April (even if the change is test-only, any new commits will trigger new dependency flow, which will disrupt the in-process servicing build) |
Member
BrennanConroy commentedApr 4, 2024
/backport to main |
Contributor
Started backporting to main:https://github.com/dotnet/aspnetcore/actions/runs/8560378502 |
Contributor
@BrennanConroy backporting to main failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patchApplying: Increase logs and delaysin CanLaunchPhotinoWebViewAndClickButtonUsing index info to reconstruct a base tree...Msrc/Components/WebView/test/E2ETest/WebViewManagerE2ETests.csFalling back to patching base and 3-way merge...Auto-merging src/Components/WebView/test/E2ETest/WebViewManagerE2ETests.csCONFLICT (content): Merge conflictin src/Components/WebView/test/E2ETest/WebViewManagerE2ETests.cserror: Failed to mergein the changes.hint: Use'git am --show-current-patch=diff' to see the failed patchPatch failed at 0001 Increase logs and delaysin CanLaunchPhotinoWebViewAndClickButtonWhen you have resolved this problem, run"git am --continue".If you prefer to skip this patch, run"git am --skip" instead.To restore the original branch and stop patching, run"git am --abort".Error: The process'/usr/bin/git' failed withexit code 128 Please backport manually! |
Contributor
@BrennanConroy an error occurred while backporting to main, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Member
BrennanConroy commentedApr 4, 2024
@Eilon please make sure this gets to main, or approve thequarantine PR and leave the issue open for someone to investigate. |
oskogstad referenced this pull request in Altinn/dialogportenMay 26, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [Microsoft.AspNetCore.Authentication.JwtBearer](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.AspNetCore.OpenApi](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)||[Microsoft.EntityFrameworkCore.Relational](https://docs.microsoft.com/ef/core/)([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)||[Microsoft.EntityFrameworkCore.Tools](https://docs.microsoft.com/ef/core/)([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.Extensions.Caching.StackExchangeRedis](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [Microsoft.Extensions.Http.Polly](https://asp.net/)([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5`|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>dotnet/aspnetcore(Microsoft.AspNetCore.Authentication.JwtBearer)</summary>###[`v8.0.5`](https://togithub.com/dotnet/aspnetcore/releases/tag/v8.0.5):.NET 8.0.5[Release](https://togithub.com/dotnet/core/releases/tag/v8.0.5)##### What's Changed- \[release/8.0] Update dependencies from dotnet/source-build-externalsby [@​dotnet-maestro](https://togithub.com/dotnet-maestro) in[https://github.com/dotnet/aspnetcore/pull/54744](https://togithub.com/dotnet/aspnetcore/pull/54744)- Update branding to 8.0.5 by[@​vseanreesermsft](https://togithub.com/vseanreesermsft) in[https://github.com/dotnet/aspnetcore/pull/54907](https://togithub.com/dotnet/aspnetcore/pull/54907)- \[release/8.0] Convert to 1ES templates by[@​RussKie](https://togithub.com/RussKie) in[https://github.com/dotnet/aspnetcore/pull/54660](https://togithub.com/dotnet/aspnetcore/pull/54660)- Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton by[@​Eilon](https://togithub.com/Eilon) in[https://github.com/dotnet/aspnetcore/pull/54608](https://togithub.com/dotnet/aspnetcore/pull/54608)- \[release/8.0] (deps): Bump src/submodules/googletest from `31993df`to `77afe8e` by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/dotnet/aspnetcore/pull/54872](https://togithub.com/dotnet/aspnetcore/pull/54872)- \[release/8.0] Reduce helix-matrix timeout to 5 hours by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/54778](https://togithub.com/dotnet/aspnetcore/pull/54778)- \[release/8.0] Preserve RemoteAuthenticationContext during trimming ifused in JS interop by [@​halter73](https://togithub.com/halter73)in[https://github.com/dotnet/aspnetcore/pull/54655](https://togithub.com/dotnet/aspnetcore/pull/54655)- \[release/8.0] Improve usage of `Type.GetType` when activating typesin data protection by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/54762](https://togithub.com/dotnet/aspnetcore/pull/54762)- \[release/8.0] Fix route analyzer performance with highly concatenatedstrings by [@​github-actions](https://togithub.com/github-actions)in[https://github.com/dotnet/aspnetcore/pull/54763](https://togithub.com/dotnet/aspnetcore/pull/54763)- \[release/8.0] Suppress .ps1 SDL errors by[@​wtgodbe](https://togithub.com/wtgodbe) in[https://github.com/dotnet/aspnetcore/pull/54915](https://togithub.com/dotnet/aspnetcore/pull/54915)- \[release/8.0] Backport test fixes by[@​MackinnonBuck](https://togithub.com/MackinnonBuck) in[https://github.com/dotnet/aspnetcore/pull/54912](https://togithub.com/dotnet/aspnetcore/pull/54912)- \[release/8.0] Skip SpotBugs for now by[@​wtgodbe](https://togithub.com/wtgodbe) in[https://github.com/dotnet/aspnetcore/pull/54952](https://togithub.com/dotnet/aspnetcore/pull/54952)- Merging internal commits for release/8.0 by[@​vseanreesermsft](https://togithub.com/vseanreesermsft) in[https://github.com/dotnet/aspnetcore/pull/55034](https://togithub.com/dotnet/aspnetcore/pull/55034)- \[release/8.0] Update dependencies from dotnet/arcade by[@​dotnet-maestro](https://togithub.com/dotnet-maestro) in[https://github.com/dotnet/aspnetcore/pull/55061](https://togithub.com/dotnet/aspnetcore/pull/55061)- \[release/8.0] Update Wix version by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/dotnet/aspnetcore/pull/55101](https://togithub.com/dotnet/aspnetcore/pull/55101)**Full Changelog**:dotnet/aspnetcore@v8.0.4...v8.0.5</details><details><summary>dotnet/efcore(Microsoft.EntityFrameworkCore.Relational)</summary>### [`v8.0.5`](https://togithub.com/dotnet/efcore/releases/tag/v8.0.5):EF Core 8.0.5This is a [patch release of EF Core8.0](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/8.0.5)containing only updates to dependencies. There are no additional fixesin this release beyond those already shipped in EF Core 8.0.4.</details>---### Configuration📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am onWednesday" (UTC), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/digdir/dialogporten).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->---------Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
1 task
This was referencedNov 12, 2025
Open
Open
Open
This was referencedNov 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
area-blazorIncludes: Blazor, Razor Components tell-modeIndicates a PR which is being merged during tell-mode
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really not sure what's causing the failure, especially because it fails so rarely. It seems unlikely it's a product bug (in Blazor code), so it seems more likely it's a problem with either the test infrastructure (e.g. slow machines?), or something to do with WebView2.
So if this passes on CI, then I suggest we merge this change and see what happens. And if it fails again in the future then we try additional things, such as a full retry within the test (e.g. if certain parts fail to even load, retry the whole test from scratch).
Fixes#54017