Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[main] Update dependencies from dotnet/efcore dotnet/runtime#34033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestrodotnet-maestrobot commentedJul 2, 2021•
edited
Loading

This pull request updates the following dependencies

Fromhttps://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20210710.10
  • Date Produced: 7/11/2021 5:50 AM
  • Commit: 83a4d3cc02fb04fce17b24fc09b3cdf77a12ba51
  • Branch: refs/heads/main

Fromhttps://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20210709.1
  • Date Produced: 7/9/2021 5:07 PM
  • Commit: d788e06ee73b83674099325d1988469f4f6ac720
  • Branch: refs/heads/main

…0702.2Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common From Version 6.0.0-preview.7.21351.2 -> To Version 6.0.0-preview.7.21352.2
@dotnet-maestrodotnet-maestrobot requested a review fromdougbu as acode ownerJuly 2, 2021 12:09
@ghostghost added area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labelsJul 2, 2021
Copy link

@ghostghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Auto-approving dependency update.

@ghostghost added the tell-modeIndicates a PR which is being merged during tell-mode labelJul 2, 2021
@eerhardt
Copy link
Member

@ericstj@pranavkm - the errors look interesting:

D:\workspace\_work\1\s\src\Http\Http.Results\src\Microsoft.Extensions.Logging.Generators\Microsoft.Extensions.Logging.Generators.LoggerMessageGenerator\LoggerMessage.g.cs(15,41): error CS0757: (NETCORE_ENGINEERING_TELEMETRY=Build) A partial method may not have multiple implementing declarationsD:\workspace\_work\1\s\src\Http\Http.Results\src\Microsoft.Extensions.Logging.Generators\Microsoft.Extensions.Logging.Generators.LoggerMessageGenerator\LoggerMessage.g.cs(11,157): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'ChallengeResult.Log' already contains a definition for '__ChallengeResultExecutingCallback'

Could this have been caused bydotnet/runtime#54950?

@JunTaoLuo
Copy link
Contributor

👀

@pranavkm
Copy link
Contributor

It looks like the analyzer appears both as part of the Logging.Abstractions package and the Internal transport feed. I tried settingExcludeAssets="analyzers" on the package reference but that did not seem to help (not sure if it's a result of the way we do references).

Could we remove the source generator from the transport package instead? It's an internal detail, no?

@dougbu
Copy link
Contributor

Could we remove the source generator from the transport package instead? It's an internal detail, no?

Ithink the right option is to use the transport package to get the source generator. It should then be automatically included in our targeting packs. But, I defer to@ericstj because he did#33977 for us.

</Target>

<!-- Work around https://github.com/dotnet/aspnetcore/issues/34048-->
<TargetName="_RemoveDuplicateLoggingSourceGenerator"AfterTargets="ResolvePackageAssets"Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@dougbu I did a random workaround because I couldn't getPrivateAssets /ExcludeAssets to work for some reason. Could you have a look and see if there's a better way to do this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks about right b/c Logging.Abstractions is referenced transitively so often. But, I'd like to hear from@ericstj why the offending assembly is duplicated between Logging.Abstractions and our transport package.


<ItemGroup>
<ReferenceInclude="Microsoft.AspNetCore.Http.Abstractions" />
<ReferenceInclude="Microsoft.Extensions.Logging.Abstractions" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This references are brought in from the transport package. Having / removing it does nothing, but it seemed unnecessary.

…0702.16Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common From Version 6.0.0-preview.7.21351.2 -> To Version 6.0.0-preview.7.21352.16
@dougbu
Copy link
Contributor

I'm not sure but the build failures seem to come from newly-added analyzers in dotnet/runtime. The compilation errors may be real.

…0705.1Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common From Version 6.0.0-preview.7.21351.2 -> To Version 6.0.0-preview.7.21355.1
…705.1Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design From Version 6.0.0-preview.7.21351.1 -> To Version 6.0.0-preview.7.21355.1
@dotnet-maestrodotnet-maestrobot changed the title[main] Update dependencies from dotnet/runtime[main] Update dependencies from dotnet/runtime dotnet/efcoreJul 5, 2021
…0706.2Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common From Version 6.0.0-preview.7.21351.2 -> To Version 6.0.0-preview.7.21356.2
@dotnet-maestrodotnet-maestrobot changed the title[main] Update dependencies from dotnet/runtime dotnet/efcore[main] Update dependencies from dotnet/efcore dotnet/runtimeJul 6, 2021
@TanayParikh
Copy link
Contributor

TanayParikh commentedJul 6, 2021•
edited
Loading

@pranavkm@captainsafia do you happen to have any context on theSourceGeneration failures?

/home/vsts/work/1/s/src/Components/Server/src/System.Text.Json.SourceGeneration/System.Text.Json.SourceGeneration.JsonSourceGenerator/WebEventJsonContext.g.cs(6,6): error CS0579: (NETCORE_ENGINEERING_TELEMETRY=Build) Duplicate 'global::System.CodeDom.Compiler.GeneratedCodeAttribute' attribute/home/vsts/work/1/s/src/Components/Server/src/System.Text.Json.SourceGeneration/System.Text.Json.SourceGeneration.JsonSourceGenerator/WebEventJsonContext.Int32.g.cs(7,100): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'WebEventJsonContext' already contains a definition for '_Int32'/home/vsts/work/1/s/src/Components/Server/src/System.Text.Json.SourceGeneration/System.Text.Json.SourceGeneration.JsonSourceGenerator/WebEventJsonContext.Int32.g.cs(8,99): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'WebEventJsonContext' already contains a definition for 'Int32'/home/vsts/work/1/s/src/Components/Server/src/System.Text.Json.SourceGeneration/System.Text.Json.SourceGeneration.JsonSourceGenerator/WebEventJsonContext.UInt64.g.cs(7,101): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'WebEventJsonContext' already contains a definition for '_UInt64'

https://dev.azure.com/dnceng/public/_build/results?buildId=1221577&view=logs&j=1b89928a-2219-5ef9-602f-f95beb3da4dc&t=bcce746a-741e-59b7-adec-a4a82d8c5e52&l=1117

@TanayParikh
Copy link
Contributor

@pranavkm@captainsafia do you happen to have any context on theSourceGeneration failures?

Spoke offline,51dfc46 should resolve theSourceGeneration failures. Merged inmain.

@dougbu
Copy link
Contributor

Merged inmain.

FYI it's usually not necessary to do a manual merge unless there were conflicts before./azp run comments cause GitHub to create the appropriate merge commit before starting a new AzDO pipeline run.

TanayParikh reacted with thumbs up emoji

@HaoK
Copy link
Member

Given the time sensitive nature of getting this PR in, shouldn't we unblock and then investigate?

davidfowl reacted with heart emoji

@SteveMCarroll
Copy link

Hey Team... I really appreciate all the energy going into this. It seems to me (and@davidfowl who i chatted with offline) that in this case, we aren't in too much danger of a quality downward spiral if we unblock and then coordinate on monday morning to get this cleaned up.

@davidfowl
Copy link
Member

We're gonna need to have an all hands on deck tomorrow to solve this issue. Seems like some people with context are out.@dougbu,@captainsafia ,@HaoK do we think this affects publishing in general ?

@captainsafia
Copy link
Member

I create#34272 to follow-up on some the template test changes that were made here.

@dougbu,@captainsafia ,@HaoK do we think this affects publishing in general ?

The template tests running in the non-Helix environment appear to be passing, although that doesn't say much IMO. :/

There's a new blocker on this PR that seems to be related to an exception in the test discovery code so that'll likely need to be handled before it goes in. We'll probably need to spend tomorrow looking at that + the template test failures and figuring out the smoothest way to resolve this PR.

@HaoK
Copy link
Member

Ugh test discovery failures, well if the actual runs don't fail, we can probably temporarily just turn off the test discovery check which should be harmless in the short term:

Just comment outhttps://github.com/dotnet/aspnetcore/blob/main/eng/helix/content/RunTests/Program.cs#L35

@davidfowl
Copy link
Member

@HaoK I pushed a change that reverts the use of dotnet test and comments out test discovery for now.

-script:.\eng\build.cmd -ci -nobl -noBuildRepoTasks -NoRestore -test -all -noBuildNative -projects eng\helix\helix.proj
/p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true
/p:RunTemplateTests=true /p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
/p:RunTemplateTests=false /p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Assuming something else fails and we we need another build, we should probably revert this as its not needed now that we don't build the template tests on helix, so its one less thing to remember to undo in the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just did this.

@davidfowl
Copy link
Member

@HaoK can you take a look those 2 latest changes and tell me if there's anything else that needs to be done?

@davidfowl
Copy link
Member

This was the failure on the previous run:

D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.7.21360.1\Sdks\Microsoft.NET.Sdk.BlazorWebAssembly\targets\Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets(624,5): error MSB6006: "D:\workspace\_work\1\s\.dotnet" exited with code 1. [D:\workspace\_work\1\s\src\Components\test\testassets\BasicTestApp\BasicTestApp.csproj]##[error].dotnet\sdk\6.0.100-preview.7.21360.1\Sdks\Microsoft.NET.Sdk.BlazorWebAssembly\targets\Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets(624,5): error MSB6006: (NETCORE_ENGINEERING_TELEMETRY=Build) "D:\workspace\_work\1\s\.dotnet" exited with code 1.

@HaoK
Copy link
Member

I saw that failure on the quarantined-pr pipeline too, I believe that's just the build race with the components test app that's we've been dealing with for a while, did the normal helix job succeed on the previous run? If so then I think things look good enough for now

@davidfowl
Copy link
Member

Yay a new failure:

[xUnit.net 00:00:01.71] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.71] Microsoft.AspNetCore.Http.Results.Tests: (Starting) Could not find VS test case for  (ID = 655cdc00a248e9014c635a0fc6616d58b5608cf5)[xUnit.net 00:00:01.72]      [FAIL][xUnit.net 00:00:01.72]       System.InvalidOperationException : Late bound operations cannot be performed on types or methods for which ContainsGenericParameters is true.[xUnit.net 00:00:01.72]       Stack Trace:[xUnit.net 00:00:01.72]            at System.Reflection.RuntimeMethodInfo.ThrowNoInvokeException() in System.Private.CoreLib.dll:token 0x6005226+0x44[xUnit.net 00:00:01.72]            at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in System.Private.CoreLib.dll:token 0x6005227+0xe[xUnit.net 00:00:01.72]            at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) in System.Private.CoreLib.dll:token 0x600512b+0x0[xUnit.net 00:00:01.72]         --- End of stack trace from previous location ---[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Fail) Could not find VS test case for  (ID = 655cdc00a248e9014c635a0fc6616d58b5608cf5)[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Finished) Could not find VS test case for  (ID = 655cdc00a248e9014c635a0fc6616d58b5608cf5)[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Starting) Could not find VS test case for  (ID = 90e2acdfcdf7c41888173970bd07dba93abccea5)[xUnit.net 00:00:01.73]      [FAIL][xUnit.net 00:00:01.73]       System.InvalidOperationException : Late bound operations cannot be performed on types or methods for which ContainsGenericParameters is true.[xUnit.net 00:00:01.73]       Stack Trace:[xUnit.net 00:00:01.73]            at System.Reflection.RuntimeMethodInfo.ThrowNoInvokeException() in System.Private.CoreLib.dll:token 0x6005226+0x44[xUnit.net 00:00:01.73]            at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in System.Private.CoreLib.dll:token 0x6005227+0xe[xUnit.net 00:00:01.73]            at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) in System.Private.CoreLib.dll:token 0x600512b+0x0[xUnit.net 00:00:01.73]         --- End of stack trace from previous location ---[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Fail) Could not find VS test case for  (ID = 90e2acdfcdf7c41888173970bd07dba93abccea5)[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Finished) Could not find VS test case for  (ID = 90e2acdfcdf7c41888173970bd07dba93abccea5)[xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.73] Microsoft.AspNetCore.Http.Results.Tests: (Starting) Could not find VS test case for  (ID = ef722624c739424dc1f28800aca57439962a68a5)[xUnit.net 00:00:01.73]      [FAIL][xUnit.net 00:00:01.73]       System.InvalidOperationException : Late bound operations cannot be performed on types or methods for which ContainsGenericParameters is true.[xUnit.net 00:00:01.73]       Stack Trace:[xUnit.net 00:00:01.73]            at System.Reflection.RuntimeMethodInfo.ThrowNoInvokeException() in System.Private.CoreLib.dll:token 0x6005226+0x44[xUnit.net 00:00:01.74]            at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in System.Private.CoreLib.dll:token 0x6005227+0xe[xUnit.net 00:00:01.74]            at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) in System.Private.CoreLib.dll:token 0x600512b+0x0[xUnit.net 00:00:01.74]         --- End of stack trace from previous location ---[xUnit.net 00:00:01.74] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.74] Microsoft.AspNetCore.Http.Results.Tests: (Fail) Could not find VS test case for  (ID = ef722624c739424dc1f28800aca57439962a68a5)[xUnit.net 00:00:01.74] Microsoft.AspNetCore.Http.Results.Tests: Result reported for unknown test case: [xUnit.net 00:00:01.74] Microsoft.AspNetCore.Http.Results.Tests: (Finished) Could not find VS test case for  (ID = ef722624c739424dc1f28800aca57439962a68a5)[xUnit.net 00:00:01.76]   Finished:    Microsoft.AspNetCore.Http.Results.TestsData collector 'Blame' message: All tests finished running, Sequence file will not be generated.

@HaoK
Copy link
Member

Hopefully those generics were what was causing test discovery to fail too

@davidfowl
Copy link
Member

Hopefully those generics were what was causing test discovery to fail too

Should I undo that change too?

@HaoK
Copy link
Member

Nah, this PR (hopefully) almost looks green, easy enough to try turning on the test discovery again when we do cleanup/investigations after this gets in

davidfowl reacted with thumbs up emoji

@davidfowl
Copy link
Member

I think it's hung, the helix tests usually take an hour

@davidfowl
Copy link
Member

davidfowl commentedJul 12, 2021•
edited
Loading

image

Socket tests on OSXhttps://helix.dot.net/api/jobs/2cd5acf8-e6f6-4a02-972d-b0951480dc03/workitems?api-version=2019-06-17

VS test is saying that helix is lying about the fact that all of the tests ran:

{"Version":2,"MessageType":"TestExecution.Completed","Payload": {"TestRunCompleteArgs": {"TestRunStatistics": {"ExecutedTests":58,"Stats": {"Skipped":5,"Passed":53        }      },"IsCanceled":false,"IsAborted":false,"Error":null,"AttachmentSets": [],"ElapsedTimeInRunningTests":"00:00:55.5773967","Metrics": {}    },"RunAttachments": [],"ExecutorUris": ["executor://xunit/VsTestRunner2/netcoreapp"    ]  }}

I'm gonna blame the infrastructure on this one until further notice.

@dotnet-maestrodotnet-maestrobot merged commit6c396e7 intomainJul 12, 2021
@dotnet-maestrodotnet-maestrobot deleted the darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 branchJuly 12, 2021 12:39
@ghostghost added this to the6.0-preview7 milestoneJul 12, 2021
@MattGal
Copy link
Member

I'm gonna blame the infrastructure on this one until further notice.

This is a valid assignment of blame, I fear. It'shttps://github.com/dotnet/core-eng/issues/12275. Basically, we have no idea how long to allow uploading to take (on these on-prem machines, multi-gig dump files cause all sorts of havoc sometimes) so we stop the special "what if the thread doing the uploading hangs?" timer

A mitigation is simple, and feel free to advocate for this on the issue... if we were to say somewhere "all work item uploads must finish inn minutes", then we can just set the timer appropriately and recover when this occurs. It's extremely rare though, so thus far the issue hasn't been dealt with.

davidfowl reacted with heart emoji

@ghost
Copy link

Hi@MattGal. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@davidfowldavidfowldavidfowl left review comments

@HaoKHaoKHaoK left review comments

@eerhardteerhardteerhardt left review comments

@dougbudougbuAwaiting requested review from dougbu

@BrennanConroyBrennanConroyAwaiting requested review from BrennanConroyBrennanConroy is a code owner

@javiercnjaviercnAwaiting requested review from javiercn

@TratcherTratcherAwaiting requested review from Tratcher

@PilchiePilchieAwaiting requested review from Pilchie

@halter73halter73Awaiting requested review from halter73halter73 is a code owner

+3 more reviewers

@pranavkmpranavkmpranavkm left review comments

@TanayParikhTanayParikhTanayParikh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworktell-modeIndicates a PR which is being merged during tell-modeType: Dependency Update 🔼

Projects

None yet

Milestone

6.0-preview7

Development

Successfully merging this pull request may close these issues.

18 participants

@eerhardt@JunTaoLuo@pranavkm@dougbu@TanayParikh@captainsafia@BrennanConroy@lewing@Tratcher@stephentoub@geoffkizer@davidfowl@DamianEdwards@SteveMCarroll@HaoK@MattGal@maryamariyan
[8]ページ先頭
©2009-2025 Movatter.jp