Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update using-latest-daily.md#7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
danmoseley merged 3 commits intomainfromdanmoseley-patch-1
Feb 19, 2025
Merged

Update using-latest-daily.md#7692

danmoseley merged 3 commits intomainfromdanmoseley-patch-1
Feb 19, 2025

Conversation

@danmoseley
Copy link
Member

No description provided.

CopilotAI review requested due to automatic review settingsFebruary 19, 2025 22:13
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

docs/using-latest-daily.md:49

  • There is an inconsistency in the command examples: the first example omits the 'dotnet new install' command and '--force' flag, while the second example includes them. Consider unifying both examples to improve clarity.
> Release branches are a little different. For example, for the latest build from `release/X.X` branch change the above to be `Aspire.ProjectTemplates::X.X.*-*`. For example, if you want to use the latest build from the `release/9.2` branch, change the above to be `dotnet new install Aspire.ProjectTemplates::9.2.*-* --force`

```

>[!TIP]
>Ifyou want to use the latest build from the`release/9.0-rc1` branch, change the above to be`dotnet new install Aspire.ProjectTemplates::9.0.0-rc.1.* --force`
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@wtgodbe was this correct? there's a period between rc and 1 that wasn't in 9.0-rc1. I guess , whatever

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are you saying there was a time when we were versioning packages "9.0.0-rc-{suffix}"? That doesn't sound right

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm saying the deleted line contains both "rc1" and "rc.1"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, that's fine. The branch would be named rc1, and the packages would be versioned rc.1. That's typical.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

that's fine but it means we need to document the feed for each rc, since they can't follow the obvious pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe I'm confused - it looks to me like the language here describes how to specify the package version, not the feed. Each release/9* branch will publish to the same feed (dotnet9) up until the point that we stabilize - the same is true for RC branches

@danmoseleydanmoseley merged commit5126607 intomainFeb 19, 2025
67 of 68 checks passed
@danmoseleydanmoseley deleted the danmoseley-patch-1 branchFebruary 19, 2025 22:53
@github-actionsgithub-actionsbot added the needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners labelMar 10, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wtgodbewtgodbewtgodbe approved these changes

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmoseley@wtgodbe

[8]ページ先頭

©2009-2025 Movatter.jp