Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support Existing Azure AppInsights, OpenAI, and CosmosDB#7677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eerhardt merged 3 commits intodotnet:mainfromeerhardt:ExistingAzureOpenAI
Feb 19, 2025

Conversation

@eerhardt
Copy link
Member

@eerhardteerhardt commentedFeb 19, 2025•
edited
Loading

Description

These resources don't support existing resources yet. Adding support to finish all the Azure resources for existing.

Note that for CosmosDB and Redis, we cannot explicitly set DisableLocalAuth on an existing resource because bicep doesn't support it.

Fix#7665

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

These resources don't support existing resources yet. Adding support to finish all the Azure resources for existing.Note that for CosmosDB, we only explicitly set DisableLocalAuth if WithAccessKeyAuthentication is called. We don't want to disable local auth on an existing resource if it is already enabled as that might break other uses of the resource.Fixdotnet#7665
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (10)

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:71

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:204

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:332

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:505

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:566

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:627

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:688

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:885

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:1154

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs:1278

  • The 'output.WriteLine(BicepText);' statement is redundant and should be removed.
output.WriteLine(BicepText);

…d RedisExisting Azure resources can't be directly updated in bicep. When trying to deploy these changes it raises an error "Error BCP173: The property "properties" cannot be used in an existing resource declaration. [https://aka.ms/bicep/core-diagnostics#BCP173]"
Tags={{"aspire-resource-name",infrastructure.AspireResource.Name}}
};
infrastructure.Add(cosmosAccount);
DisableLocalAuth=disableLocalAuth,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1 to this. Setting this directly on the resource instead of after the fact reads better as well.

…e added to the infrastructure in the opposite order now.
@eerhardteerhardt merged commit8447be9 intodotnet:mainFeb 19, 2025
70 checks passed
@eerhardt
Copy link
MemberAuthor

/backport to release/9.1

@github-actions
Copy link
Contributor

Started backporting torelease/9.1:https://github.com/dotnet/aspire/actions/runs/13422889047

@eerhardteerhardt deleted the ExistingAzureOpenAI branchFebruary 19, 2025 22:40
@github-actionsgithub-actionsbot added the area-integrationsIssues pertaining to Aspire Integrations packages labelMar 10, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

Copilot code reviewCopilotCopilot left review comments

@captainsafiacaptainsafiacaptainsafia approved these changes

@davidfowldavidfowlAwaiting requested review from davidfowl

@mitchdennymitchdennyAwaiting requested review from mitchdenny

@sebastienrossebastienrosAwaiting requested review from sebastienros

Assignees

No one assigned

Labels

area-integrationsIssues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Azure integrations that don't support "AsExisting"

2 participants

@eerhardt@captainsafia
[8]ページ先頭
©2009-2025 Movatter.jp