Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move env vars to bottom of resource details#6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesNK merged 1 commit intomainfromjamesnk/resource-details-env-vars-position
Oct 31, 2024

Conversation

@JamesNK
Copy link
Member

@JamesNKJamesNK commentedOct 29, 2024
edited
Loading

Description

Env vars, especially for projects, is usually the biggest section in details. Move env var to the bottom of resource details to avoid is hiding other info below it, e.g. health checks.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add<remarks /> and<code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers:Open in CodeFlow

Copy link
Member

@davidfowldavidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@JamesNKJamesNK merged commita764cca intomainOct 31, 2024
9 checks passed
@JamesNKJamesNK deleted the jamesnk/resource-details-env-vars-position branchOctober 31, 2024 06:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@davidfowldavidfowldavidfowl approved these changes

@drewnoakesdrewnoakesAwaiting requested review from drewnoakes

@adamintadamintAwaiting requested review from adamint

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesNK@davidfowl

[8]ページ先頭

©2009-2025 Movatter.jp