NotificationsYou must be signed in to change notification settings
Fork564
Star2.1k

[tests] restore`SSL` category#10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

jonathanpeppers wants to merge3 commits intomain

base:main

Choose a base branch

fromdev/peppers/ssl-crypto-tests

Draft

[tests] restore`SSL` category#10495

jonathanpeppers wants to merge3 commits intomainfromdev/peppers/ssl-crypto-tests

Conversation

Copy link

Member

jonathanpeppers commentedSep 17, 2025

We think some of the recent changes in main, should fix .NET APIs related to crypto on both CoreCLR and NativeAOT.

[tests] restoreSSL category

538d2bb

We think some of the recent changes in main, should fix .NET APIs related to crypto on both CoreCLR and NativeAOT.

Copy link

MemberAuthor

jonathanpeppers commentedSep 17, 2025

It seems like in the middle ofAndroidMessageHandlerSendsClientCertificate(False), we crash:

09-17 17:29:12.466 21031 21056 I NUnit   : AndroidMessageHandlerSendsClientCertificate(False) ...09-17 17:29:12.756 21031 21056 E droid.NET_Test: JNI ERROR (app bug): attempt to use stale Global 0x36f6 (should be 0x36f2)09-17 17:29:12.756 21031 21056 F droid.NET_Test: java_vm_ext.cc:570] JNI DETECTED ERROR IN APPLICATION: use of deleted global reference 0x36f609-17 17:29:12.756 21031 21056 F droid.NET_Test: java_vm_ext.cc:570]     from void crc643df67da7b13bb6b1.TestInstrumentation_1.n_onStart()

Copy link

Contributor

grendello commentedSep 18, 2025

It seems like in the middle ofAndroidMessageHandlerSendsClientCertificate(False), we crash:

09-17 17:29:12.466 21031 21056 I NUnit   : AndroidMessageHandlerSendsClientCertificate(False) ...09-17 17:29:12.756 21031 21056 E droid.NET_Test: JNI ERROR (app bug): attempt to use stale Global 0x36f6 (should be 0x36f2)09-17 17:29:12.756 21031 21056 F droid.NET_Test: java_vm_ext.cc:570] JNI DETECTED ERROR IN APPLICATION: use of deleted global reference 0x36f609-17 17:29:12.756 21031 21056 F droid.NET_Test: java_vm_ext.cc:570]     from void crc643df67da7b13bb6b1.TestInstrumentation_1.n_onStart()

Might possibly be a GC bridge bug? /cc@simonrozsival

Copy link

Member

simonrozsival commentedSep 18, 2025

That might be a GC bridge bug or it could be a bug in runtime's Crypto PAL code which also uses JNI.

@jonathanpeppers can you repro it locally?

Merge branch 'main' into dev/peppers/ssl-crypto-tests

f288b94

Copy link

MemberAuthor

jonathanpeppers commentedSep 18, 2025

After fixing merge conflict with main, it seems like these passed on CoreCLR and nothing crashed.

NativeAOT has some failures like:

Certificate validationExpected: No Exception to be thrownBut was:   (net_auth_SSPI)at System.Net.Security.SslStream.<ForceAuthenticationAsync>d__159`1.MoveNext() + 0xa9f--- End of stack trace from previous location ---at System.NetTests.SslTest.DoVerifyTrustedCertificates() + 0xb1at System.NetTests.SslTest.RunIgnoringWebException(Action test) + 0x34at NUnit.Framework.Constraints.VoidInvocationDescriptor.Invoke() + 0xcat NUnit.Framework.Constraints.ExceptionInterceptor.Intercept(Object) + 0x2a

So, let me change this to only add the category to CoreCLR and see if it is green.

Update Mono.Android.NET-Tests.csproj

ab907bd

Copy link

MemberAuthor

jonathanpeppers commentedSep 18, 2025

Seems like CI gets the same error, but it's working for me locally:

# arm64 device.\dotnet-local.cmd build tests\Mono.Android-Tests\Mono.Android-Tests\Mono.Android.NET-Tests.csproj-t:Install,RunTestApks-r android-arm64-bl-p:IncludeCategories=SSL-p:UseMonoRuntime=false-c Release# API 29 emulator.\dotnet-local.cmd build tests\Mono.Android-Tests\Mono.Android-Tests\Mono.Android.NET-Tests.csproj-t:Install,RunTestApks-r android-x64-bl-p:IncludeCategories=SSL-p:UseMonoRuntime=false-c Release