- Notifications
You must be signed in to change notification settings - Fork564
[release/9.0.1xx] introduce$(_AndroidIsAssignableFromCheck) escape hatch#10473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… hatchContext:https://github.com/jonathanpeppers/IntuneReproNet9Context:35f41dcContext:9a27140.NET 9 introduced a Java "instanceof" check for multiple reasons: if (!JniEnvironment.Types.IsAssignableFrom (handleClass, typeClass)) { return null; }The problem with this check, is that it fails in combination with thepackage: <PackageReference Include="Microsoft.Intune.Maui.Essentials.android" Version="11.0.0-develop" />`LayoutInflater.From (Context)` returns `null` due to: Handle 0x7f346ad02d is of type 'com/android/internal/policy/PhoneLayoutInflater' which is not assignable to'com/microsoft/intune/mam/client/view/MAMLayoutInflater'To solve this:* Introduce `-p:_AndroidIsAssignableFromCheck=false` to disable the check, defaulting to `true` for .NET 9+.* Add a test that calls `LayoutInflater.From (Context)` and verify it returns non-null.* Add a test entry in `Remaps.xml` to remap `com.microsoft.intune.mam.client.view.MAMLayoutInflater` to a test Java class `net.dot.android.test.MyLayoutInflater` that extends `android.view.LayoutInflater`.I introduced a new test run configuration "IsAssignableFrom"to leverage the new property `-p:_AndroidIsAssignableFromCheck=false`.After this is merged, I'll need to manually port this to main for .NET10. Various files have moved around there; we can use `RuntimeFeature.cs`, etc.
Comment on lines +13 to +17
| <RuntimeHostConfigurationOptionInclude="Microsoft.Android.Runtime.RuntimeFeature.IsAssignableFromCheck" | ||
| Condition="'$(_AndroidIsAssignableFromCheck)' != ''" | ||
| Value="$(_AndroidIsAssignableFromCheck)" | ||
| Trim="true" | ||
| /> |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to set even in Debug mode.
Comment on lines 47 to +48
| <_AndroidRemapMembersInclude="Remaps.xml" /> | ||
| <_AndroidRemapMembersInclude="IsAssignableFromRemaps.xml"Condition=" '$(_AndroidIsAssignableFromCheck)' == 'false'" /> |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IsAssignableFromRemaps.xml is in its own file, because we have a couple tests that need to use thereal Android LayoutInflater.
We run only theIntune category under-p:_AndroidIsAssignableFromCheck=false.
MemberAuthor
jonathanpeppers commentedSep 10, 2025
New test passes, things look good: The log messages say: |
simonrozsival approved these changesSep 11, 2025
MemberAuthor
jonathanpeppers commentedSep 11, 2025
This looks green, there are just a couple networking-related failures we can ignore: |
f395493 intorelease/9.0.1xx 55 of 57 checks passed
Uh oh!
There was an error while loading.Please reload this page.
jonathanpeppers added a commit that referenced this pull requestSep 11, 2025
Forward port of:#10473Context:https://github.com/jonathanpeppers/IntuneReproNet9Context:35f41dcContext:9a27140.NET 9 introduced a Java "instanceof" check for multiple reasons: if (!JniEnvironment.Types.IsAssignableFrom (handleClass, typeClass)) { return null; }The problem with this check, is that it fails in combination with thepackage: <PackageReference Include="Microsoft.Intune.Maui.Essentials.android" Version="11.0.0-develop" />`LayoutInflater.From (Context)` returns `null` due to: Handle 0x7f346ad02d is of type 'com/android/internal/policy/PhoneLayoutInflater' which is not assignable to'com/microsoft/intune/mam/client/view/MAMLayoutInflater'To solve this:* Introduce `-p:_AndroidIsAssignableFromCheck=false` to disable the check, defaulting to `true` for .NET 9+.* Add a test that calls `LayoutInflater.From (Context)` and verify it returns non-null.* Add a test entry in `IsAssignableFromRemaps.xml` to remap `com.microsoft.intune.mam.client.view.MAMLayoutInflater` to a test Java class `net.dot.android.test.MyLayoutInflater` that extends `android.view.LayoutInflater`.I introduced a new test run configuration "IsAssignableFrom"to leverage the new property `-p:_AndroidIsAssignableFromCheck=false`,and only run the `Intune` category.
grendello pushed a commit that referenced this pull requestSep 15, 2025
…tch (#10475)Forward port of:#10473Context:https://github.com/jonathanpeppers/IntuneReproNet9Context:35f41dcContext:9a27140.NET 9 introduced a Java "instanceof" check for multiple reasons: if (!JniEnvironment.Types.IsAssignableFrom (handleClass, typeClass)) { return null; }The problem with this check, is that it fails in combination with the package: <PackageReference Include="Microsoft.Intune.Maui.Essentials.android" Version="11.0.0-develop" />`LayoutInflater.From (Context)` returns `null` due to: Handle 0x7f346ad02d is of type 'com/android/internal/policy/PhoneLayoutInflater' which is not assignable to 'com/microsoft/intune/mam/client/view/MAMLayoutInflater'To solve this:* Introduce `-p:_AndroidIsAssignableFromCheck=false` to disable the check, defaulting to `true` for .NET 9+.* Add a test that calls `LayoutInflater.From (Context)` and verify it returns non-null.* Add a test entry in `IsAssignableFromRemaps.xml` to remap `com.microsoft.intune.mam.client.view.MAMLayoutInflater` to a test Java class `net.dot.android.test.MyLayoutInflater` that extends `android.view.LayoutInflater`.I introduced a new test run configuration "IsAssignableFrom" to leverage the new property `-p:_AndroidIsAssignableFromCheck=false`, and only run the `Intune` category.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Context:https://github.com/jonathanpeppers/IntuneReproNet9
Context:35f41dc
Context:9a27140
.NET 9 introduced a Java "instanceof" check for multiple reasons:
The problem with this check, is that it fails in combination with the package:
LayoutInflater.From (Context)returnsnulldue to:To solve this:
Introduce
-p:_AndroidIsAssignableFromCheck=falseto disable the check, defaulting totruefor .NET 9+.Add a test that calls
LayoutInflater.From (Context)and verify it returns non-null.Add a test entry in
Remaps.xmlto remapcom.microsoft.intune.mam.client.view.MAMLayoutInflaterto a test Java classnet.dot.android.test.MyLayoutInflaterthat extendsandroid.view.LayoutInflater.I introduced a new test run configuration "IsAssignableFrom" to leverage the new property
-p:_AndroidIsAssignableFromCheck=false.After this is merged, I'll need to manually port this to main for .NET 10. Various files have moved around there; we can use
RuntimeFeature.cs, etc.