- Notifications
You must be signed in to change notification settings - Fork564
[clr] fix environment variable setting#10395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
In case of an odd count of envvars, we'd fail to set them becauseof an old check that should have been removed inf37158eRemove verification that there's an even number of elements in theenvironment variable array, it is no longer necessary.
c7d8f5b tocde47e3CompareContributorAuthor
grendello commentedAug 8, 2025
/azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers approved these changesAug 8, 2025
12f8376 intomain 60 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#10382
Context:f37158e
f37158e switched to string blobs when storing environment variables
in
libxamarin-app.so.In case of an odd count of envvars, we'd fail to set them because
of a check that should have been removed inf37158e
Remove verification that there's an even number of elements in the
environment variable array, it is no longer necessary.