- Notifications
You must be signed in to change notification settings - Fork564
[xabt] fix missing.nupkg output fordotnet pack#10270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixes:#9974After updating the `DotnetPack` test to use: proj.OtherBuildItems.Add (new AndroidItem.AndroidMavenLibrary ("org.jetbrains.kotlinx:kotlinx-serialization-json-jvm") { MetadataValues = "Version=1.3.3;Bind=false", BinaryContent = () => [], });And then seeing the `.jar` files inside: using var aarStream = new MemoryStream (); var aarEntry = nupkg.ReadEntry (aarPath); aarEntry.Extract (aarStream); aarStream.Seek (0, SeekOrigin.Begin); using var aar = ZipArchive.Open (aarStream); int count = aar.Count (e => e.FullName.StartsWith ("libs/", StringComparison.OrdinalIgnoreCase) && e.FullName.EndsWith (".jar", StringComparison.OrdinalIgnoreCase));There were originally 0 files, when there *should* be 2!Reviewing the `.binlog`, `dotnet pack` has an inner/outer build goingon during it:* `_WalkEachTargetPerFramework` target* Runs `<MSBuild/>`, the `_GetFrameworkAssemblyReferences` target* Which calls our `_CreateAar` target.If `_CreateAar` can be called in this scenario, it needs to depend on`_CategorizeAndroidLibraries`, so none of its inputs are missing.With this change, the test now asserts that 2 "hashed `.jar` files arepresent in the `.nupkg` output.
grendello approved these changesJul 10, 2025
6c2ac38 intomain 59 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:#9974
After updating the
DotnetPacktest to use:And then seeing the
.jarfiles inside:There were originally 0 files, when thereshould be 2!
Reviewing the
.binlog,dotnet packhas an inner/outer build going on during it:_WalkEachTargetPerFrameworktargetRuns
<MSBuild/>, the_GetFrameworkAssemblyReferencestargetWhich calls our
_CreateAartarget.If
_CreateAarcan be called in this scenario, it needs to depend on_CategorizeAndroidLibraries, so none of its inputs are missing.With this change, the test now asserts that 2 "hashed"
.jarfiles are present in the.nupkgoutput.