- Notifications
You must be signed in to change notification settings - Fork564
[xabt] remove unused MSBuild tasks#10209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Context:#10206@copilot found these in#10206, so I checked their usage one-by-one toremove completely unused code.Many of these look *very* old, like `<GetConvertedJavaLibraries/>` forexample, mentions an old Android tool named `jack`.Removing the `<UsingTask>` declarations should also slightly improveMSBuild evaluation time. From what I've seen profiling in the past,MSBuild creates a full path string for each `AssemblyFile` entry.
04c44a8 intomain 59 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:#10206
@copilot found these in#10206, so I checked their usage one-by-one to remove completely unused code.
Many of these lookvery old, like
<GetConvertedJavaLibraries/>for example, mentions an old Android tool namedjack.Removing the
<UsingTask>declarations should also slightly improve MSBuild evaluation time. From what I've seen profiling in the past, MSBuild creates a full path string for eachAssemblyFileentry.