- Notifications
You must be signed in to change notification settings - Fork564
[XABT] Make NRT opt-out instead of opt-in.#10093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
17d802b tob95b11cComparejonathanpeppers approved these changesApr 30, 2025
Member
jonathanpeppers left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This project has<WarningsAsErrors>Nullable</WarningsAsErrors>, so since the build is green it didn't add any new NRT warnings. 👍
395189c intomain 59 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Help ensure we do not unintentionally add any additional non-NRT aware code to
Xamarin.Android.Build.Tasksby switching$(Nullable)fromannotationtoenable. This will subject any new files to NRT analysis by default unless they opt out with#nullable disable.To switch to this mode:
#nullable disableto any existing code files that have not been converted and currently have NRT warnings. (~200 files)#nullable enablefrom any existing code files that have already been converted. (~50 files)