- Notifications
You must be signed in to change notification settings - Fork311
[6.0] Add new trusted AKV URLs for FR and DE#3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:release/6.0
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Added 4 new trusted AKV URLs.- Fixed existing manual tests and added unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR ports changes from main to release/6.0 that add support for 4 new trusted Azure Key Vault URLs for France and Germany sovereign clouds, along with corresponding test improvements. The changes ensure compatibility with C# 9.0 syntax requirements for the 6.0 release branch.
- Adds 4 new trusted AKV URLs for sovereign clouds (France and Germany)
- Improves test organization and adds comprehensive unit tests for URL validation
- Fixes C# 9.0 compatibility issues in exception handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Reorganizes test file references and adds new TrustedUrlsTest.cs |
| TrustedUrlsTest.cs | New comprehensive test class for validating trusted and untrusted AKV URLs |
| ExceptionTestAKVStore.cs | Updates to use shared error message generation from TrustedUrlsTest |
| Utils.cs | Changes return type from Exception to ArgumentException for better type safety |
| Constants.cs | Adds 4 new sovereign cloud AKV endpoints and improves code formatting |
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TrustedUrlsTest.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Port of#3482 from main to release/6.0