- Notifications
You must be signed in to change notification settings - Fork311
WIP | Create Extensions package#3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added commentary for reviewers and found some things to fix.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -327,9 +349,8 @@ stages: | |||
| # ways to detect if they were present) won't run consistently across forks and non-forks. | |||
| ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: | |||
| AADPasswordConnectionString: $(AAD_PASSWORD_CONN_STR) | |||
| AADServicePrincipalId: $(AADServicePrincipalId) | |||
| ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My YAML linter was complaining about duplicate keys because these${{if ...} lines are the same. Similar changes below for the enclave test configurations.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| used by the build tooling and may be unintentionally included in other | ||
| (non-MDS) projects. | ||
| --> | ||
| <NugetPackageVersionCondition="'$(NugetPackageVersion)' == ''">$(MdsVersionDefault).$(BuildNumber)-dev</NugetPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor tweak here - I added$(BuildNumber) - not sure if that's helpful, but it matches how the Extensions package does things.
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ba927b7 to6a52edeComparecodecovbot commentedJul 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3471 +/- ##==========================================- Coverage 68.85% 64.67% -4.18%========================================== Files 277 277 Lines 62237 62237 ==========================================- Hits 42854 40253 -2601- Misses 19383 21984 +2601
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b656a9f to505eb2eCompare- Added empty Extensions package with some sample class and docs to demonstrate packaging.- Created CI stage to build, test, pack, and publish the Extensions NuGet package.- Updated downstream CI stages/jobs to use the Extensions package.- Updated build.proj Clean target to not delete packages/ dir.
73f95b1 to0f7fdbfCompare
Description
Work in Progress - This PR is a draft while I get the CI machinery working.
As part of the Azure split work, a new Extensions package is being created that contains types shared between MDS and its future extensions (Azure will be the first). This PR creates that package (with no meaningful content) to setup the MDS dependency, and get testing and CI setup accordingly.
I'm also experimenting with simplified .slnx files and some project directory structure changes.
Issues
The first step towards#1108.
Testing