Description

This follows up#3431 - sorry if I'm treading on your toes here@benrr101. It's a fairly bulky set of changes, but most of this bulk comes from removing the methods in ValueUtilsSmi which accepted and passedSmiEventSink_Default parameters. The majority of the work is handled in the first three methods.

My process here is clearest when considered in the context ofSmiEventSink_Default.cs:

1. ProcessMessagesAndThrow only does work if called whenHasMessages is true.
2. HasMessages is only true if_errors or_warnings is non-null.
3. Both variables are private in scope. They are only ever assigned to inProcessMessages, and in both cases they're set to null.
4. Based on this,HasMessages is always false, andProcessMessagesAndThrow never does anything. It can be removed.
5. ProcessMessagesAndThrow was the only member (besides the constructor) accessed on the class.

I thus removed the entire class and every reference to it. This has knock-on effects on SqlDataReader's target-specific files, (which can be merged and removed) but those can be cleaned up later.

Testing

Unit tests and manual tests pass, although I'd appreciate a CI run.