Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Introduce SqlVectorFloat32 SqlType class for vector datatype support#3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
13 commits
Select commitHold shift + click to select a range
811f433
Feature Extension Changes for Vector Datatype Support (#3209)
apoorvdeshmukhApr 16, 2025
44109e4
Add vector datatype support for Float32 with SqlVectorFloat32
apoorvdeshmukhJun 19, 2025
0abd4d2
Add test coverage for float32 vector datatype
apoorvdeshmukhJun 20, 2025
d04dc5c
Merge remote-tracking branch 'origin/main' into dev/vector/SqlVectorF…
apoorvdeshmukhJun 24, 2025
5ddc4dd
Fix ref assembly for ci-package and add merge conflict resolutions fo…
apoorvdeshmukhJun 24, 2025
c2033c5
Address review comments
apoorvdeshmukhJun 24, 2025
79f3583
Merge remote-tracking branch 'origin/main' into dev/vector/SqlVectorF…
apoorvdeshmukhJun 24, 2025
cb6946f
Minor error msg correction
apoorvdeshmukhJun 24, 2025
5d58c6a
Disable vector tests until server image with vector support is availa…
apoorvdeshmukhJun 24, 2025
f227c0b
Fix the check for vector null values
apoorvdeshmukhJun 24, 2025
810648a
Merge remote-tracking branch 'origin/main' into dev/vector/SqlVectorF…
apoorvdeshmukhJun 25, 2025
2e2b80a
Address review comments and CI failures
apoorvdeshmukhJun 25, 2025
897a6f6
Remove netcore SqlBulkCopy
apoorvdeshmukhJun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Add test coverage for float32 vector datatype
  • Loading branch information
@apoorvdeshmukh
apoorvdeshmukh committedJun 20, 2025
commit0abd4d29d7cb395a8a26226b4393f486074b484c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1141,8 +1141,8 @@ internal static ArgumentException BadParameterName(string parameterName)
return e;
}

internal static Exception NullOutputParameterValueForVector()
=> InvalidOperation(StringsHelper.GetString(Strings.ADP_NullOutputParameterValueForVector));
internal static Exception NullOutputParameterValueForVector(string paramName)
=> InvalidOperation(StringsHelper.GetString(Strings.ADP_NullOutputParameterValueForVector, paramName));

internal static ArgumentException InvalidVectorHeader()
=> Argument(StringsHelper.GetString(Strings.ADP_InvalidVectorHeader));
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1926,7 +1926,7 @@ private MetaType GetMetaTypeOnly()
{
if (_metaType != null)
{
if (_metaType.SqlDbType == SqlDbTypeExtensions.Vector && (_value == null || _value == DBNull.Value))
if (_metaType.SqlDbType == SqlDbTypeExtensions.Vector && (_direction == ParameterDirection.Input) && (_value == null || _value == DBNull.Value))
{
_value = DBNull.Value;
return MetaType.GetDefaultMetaType();
Expand DownExpand Up@@ -1958,6 +1958,7 @@ private MetaType GetMetaTypeOnly()
return MetaType.GetMetaTypeFromType(valueType);
}
}

return MetaType.GetDefaultMetaType();
}

Expand DownExpand Up@@ -2035,9 +2036,9 @@ internal void Validate(int index, bool isCommandProc)
GetCoercedValue();
}

if (metaType.SqlDbType == SqlDbTypeExtensions.Vector && _value == null && (Direction == ParameterDirection.Output || Direction == ParameterDirection.InputOutput))
if (metaType.SqlDbType == SqlDbTypeExtensions.Vector &&(_value == null || _value == DBNull.Value) && (Direction == ParameterDirection.Output || Direction == ParameterDirection.InputOutput))
{
throw ADP.NullOutputParameterValueForVector();
throw ADP.NullOutputParameterValueForVector(_parameterName);
}

//check if the UdtTypeName is specified for Udt params
Expand Down
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4750,7 +4750,7 @@
<value>Unsupported Vector type '{0}'.</value>
</data>
<data name="ADP_NullOutputParameterValueForVector" xml:space="preserve">
<value>'null' value not supported for output paramter of SqlDbtype Vector.</value>
<value>'null' value not supported for output paramter'{0}'of SqlDbtype Vector.</value>
</data>
<data name="ADP_InvalidVectorHeader" xml:space="preserve">
<value>Invalid vector header received.</value>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -299,6 +299,7 @@
<Compile Include="SQL\JsonTest\JsonStreamTest.cs" />
<Compile Include="SQL\JsonTest\JsonTest.cs" />
<Compile Include="SQL\VectorTest\VectorTypeBackwardCompatibilityTests.cs" />
<Compile Include="SQL\VectorTest\NativeVectorFloat32Tests.cs" />
<Compile Include="SQL\SqlCommand\SqlCommandStoredProcTest.cs" />
<Compile Include="TracingTests\TestTdsServer.cs" />
<Compile Include="XUnitAssemblyAttributes.cs" />
Expand Down
Loading
Loading
[8]ページ先頭
©2009-2025 Movatter.jp