Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change TryReadString to use TryReadBytesWithContinue#3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 4 commits intodotnet:mainfromWraith2:fix-3421
Jun 24, 2025

Conversation

Wraith2
Copy link
Contributor

Fixes#3421

Digging into the replication provided I found that if the data type of the string column were changed fromntext tonvarchar(max) everything worked as expected. The reason for this is that the two types are handled differently internally despite being value equivalent to the user. nvarchar() is a plp type and ntext is not. non-plp strings pass through the TryReadString function and it was tripping up when hitting the continue point because it had not been altered to deal with it.

TryReadString was using TryReadByteArray and in previous work I have written a version of this which encapsulates continue capable logic, TryReadByteArrayWithContinue. I moved this method down from TdsParser to TdsParserStateObject so it sits at the same level as the original method and then called it from TryReadString. This resolves the problem with minimal changes and no new code.

  • The ability to use the existing api with minor rearrangements is pleasing and I think promising that we've got all the tools we need to handle continue.
  • The code coverage for strings is alarming. I thought that we would have a lot better coverage than we seem to. Strings are a very common path and yet we've found at least 3 combinations that I would have expected to have coverage.
  • This really need to go into Preview 2 to make sure anyone testing the preview has as many fixes as possible and that we pick up any new issues cleanly with preview2. @dotnet/sqlclientdevteam@David-Engel

/cc@ErikEJ@Kobuntu

ErikEJ and edwardneal reacted with hooray emojiDavid-Engel and cheenamalhotra reacted with heart emoji
@Wraith2Wraith2 requested a review froma team as acode ownerJune 15, 2025 22:56
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@paulmedynskipaulmedynski added Bug! 🐛Issues that are bugs in the drivers we maintain. P2Use to label moderate priority issue - impacts atleast more than 1 customer. labelsJun 16, 2025
@paulmedynskipaulmedynski added this to the6.1-preview2 milestoneJun 16, 2025
paulmedynski
paulmedynski previously approved these changesJun 16, 2025
@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@ErikEJErikEJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

cheenamalhotra
cheenamalhotra previously approved these changesJun 18, 2025
Copy link
Member

@cheenamalhotracheenamalhotra left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small change to remove old cleanup query, rest LGTM!

benrr101
benrr101 previously approved these changesJun 18, 2025
Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Low stakes comments on the test more than anything

@cheenamalhotracheenamalhotra removed the Bug! 🐛Issues that are bugs in the drivers we maintain. labelJun 19, 2025
paulmedynski
paulmedynski previously approved these changesJun 20, 2025
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

paulmedynski
paulmedynski previously approved these changesJun 22, 2025
@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedJun 24, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is95.23810% with1 line in your changes missing coverage. Please review.

Project coverage is 62.70%. Comparing base(1058566) to head(a8862a9).
Report is 11 commits behind head on main.

Files with missing linesPatch %Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs0.00%1 Missing⚠️

❗ There is a different number of reports uploaded between BASE (1058566) and HEAD (a8862a9). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (1058566)HEAD (a8862a9)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3422      +/-   ##==========================================- Coverage   68.43%   62.70%   -5.73%==========================================  Files         299      285      -14       Lines       65418    63321    -2097     ==========================================- Hits        44766    39706    -5060- Misses      20652    23615    +2963
FlagCoverage Δ
addons?
netcore67.00% <100.00%> (-5.57%)⬇️
netfx61.87% <95.00%> (-5.30%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commit44762d9 intodotnet:mainJun 24, 2025
237 checks passed
@Wraith2Wraith2 deleted the fix-3421 branchJune 24, 2025 22:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ErikEJErikEJErikEJ left review comments

@David-EngelDavid-EngelDavid-Engel left review comments

@benrr101benrr101benrr101 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@paulmedynskipaulmedynskiAwaiting requested review from paulmedynski

Assignees
No one assigned
Labels
P2Use to label moderate priority issue - impacts atleast more than 1 customer.
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

TdsParser: Fatal connection error
6 participants
@Wraith2@paulmedynski@cheenamalhotra@benrr101@ErikEJ@David-Engel

[8]ページ先頭

©2009-2025 Movatter.jp