- Notifications
You must be signed in to change notification settings - Fork311
Merge | DbConnectionString#3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
# Conflicts:#src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR consolidates theDbConnectionString class into the common project and renames it fromDBConnectionString to follow naming conventions, updating all consumers accordingly.
- Renamed and relocated
DBConnectionStringtoDbConnectionStringunderCommon - Updated
SqlClientPermissionto reference the renamed class - Adjusted the .csproj to include the new file and remove the old compile entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SqlClientPermission.netfx.cs | Switched fromDBConnectionString toDbConnectionString usage |
| DbConnectionString.netfx.cs | Renamed class and replaced KEY constants withDbConnectionStringKeywords and synonyms |
| netfx/src/Microsoft.Data.SqlClient.csproj | Added compile include forDbConnectionString.netfx.cs, removedDBConnectionString.cs |
Comments suppressed due to low confidence (2)
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj:951
- Verify the surrounding
<ItemGroup>tags after removing this closing tag and the next<ItemGroup>to ensure the XML structure remains valid and all<Compile>entries are grouped correctly.
</ItemGroup>src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlClientPermission.netfx.cs:65
- [nitpick] Consider adding or updating unit tests around permission entries that use
DbConnectionStringto ensure behavior hasn’t regressed after the rename.
AddPermissionEntry(new DbConnectionString(constr));...rosoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionString.netfx.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedJun 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3416 +/- ##=========================================+ Coverage 0 92.58% +92.58%========================================= Files 0 6 +6 Lines 0 310 +310 =========================================+ Hits 0 287 +287- Misses 0 23 +23
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
95253ac intomainUh oh!
There was an error while loading.Please reload this page.
Description
This merge PR is pretty simple. It moves the DbConnectionString class from the netfx project into the common project. It was originally named DBConnectionString but is now renamed to DbConnectionString to follow naming conventions (after@paulmedynski caused a bunch of merge conflicts fixing broken link to the old name...)
I developed this PR on top of some cleanup work for DbConnectionOptions that I rebased off of. There may be some remnants of those changes in this PR.
Issues
Continues work on#1261
Testing
Class is just being renamed and moved, project still builds, CI should be good to verify.