Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix wrong error message#3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
paulmedynski merged 1 commit intodotnet:mainfromErikEJ:issue-3410
Jun 12, 2025
Merged

Conversation

ErikEJ
Copy link
Contributor

fixes#3410

@CopilotCopilotAI review requested due to automatic review settingsJune 11, 2025 16:07
@ErikEJErikEJ requested a review froma team as acode ownerJune 11, 2025 16:07
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes an incorrect enum type reference in the exception thrown byConvertToPoolBlockingPeriod.

  • Corrects the enum type passed toADP.InvalidEnumerationValue
  • Ensures the error message now referencesPoolBlockingPeriod instead ofApplicationIntent
Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/PoolBlockingUtilities.cs:131

  • Consider adding a unit test to verify that an invalidPoolBlockingPeriod value triggersInvalidEnumerationValue and correctly mentionsPoolBlockingPeriod in the exception message.
throw ADP.InvalidEnumerationValue(typeof(PoolBlockingPeriod), (int)eValue);

@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ErikEJ
Copy link
ContributorAuthor

@cheenamalhotra Pipeline errors seem unrelated?

@cheenamalhotra
Copy link
Member

Yes, looks like that.

@paulmedynskipaulmedynski merged commit4a7f50d intodotnet:mainJun 12, 2025
237 checks passed
@paulmedynskipaulmedynski added this to the6.1-preview2 milestoneJun 12, 2025
@codecovCodecov
Copy link

codecovbot commentedJun 12, 2025

Codecov Report

Attention: Patch coverage is0% with1 line in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base(e649a7c) to head(bdfbacf).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
...a/Common/ConnectionString/PoolBlockingUtilities.cs0.00%1 Missing⚠️

❗ There is a different number of reports uploaded between BASE (e649a7c) and HEAD (bdfbacf). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (e649a7c)HEAD (bdfbacf)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3411      +/-   ##==========================================- Coverage   68.33%   61.89%   -6.45%==========================================  Files         301      295       -6       Lines       65631    65321     -310     ==========================================- Hits        44849    40428    -4421- Misses      20782    24893    +4111
FlagCoverage Δ
addons?
netcore66.97% <0.00%> (-5.64%)⬇️
netfx60.33% <0.00%> (-6.67%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

PoolBlockingUtilities incorrectly uses typeof(ApplicationIntent) instead of typeof(PoolBlockingPeriod)
3 participants
@ErikEJ@paulmedynski@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp