Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | SqlBulkCopy#3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 12 commits intomainfromdev/russellben/merge/sqlbulkcopy
Jun 20, 2025
Merged

Merge | SqlBulkCopy#3405

benrr101 merged 12 commits intomainfromdev/russellben/merge/sqlbulkcopy
Jun 20, 2025

Conversation

benrr101
Copy link
Contributor

Description

This PR merges the SqlBulkCopy from both netfx and netcore projects into a single instance in the common project. This was surprisingly easy, as the vast majority of the two versions were identical. I'll add callouts in the diff for the few differences that needed to be addressed, though in most cases, the netcore versions were taken since they were slightly more performant than the netfx version.

There is also a lot of stubs added to common projects. This was just to make it easier to verify that the file is error-free when working in the common project. If necessary, I can drop these from the PR.

Issues

More work for#1261

Testing

Code is mostly just moved, so CI should validate the behavior.

edwardneal reacted with rocket emoji
@CopilotCopilotAI review requested due to automatic review settingsJune 9, 2025 22:27
@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelJun 9, 2025
@benrr101benrr101 requested a review froma team as acode ownerJune 9, 2025 22:27
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

paulmedynski
paulmedynski previously approved these changesJun 11, 2025
paulmedynski
paulmedynski previously approved these changesJun 12, 2025
@codecovCodecov
Copy link

codecovbot commentedJun 19, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is39.39394% with40 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base(95253ac) to head(096efcc).
Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
...Client/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs48.14%28 Missing⚠️
....SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs0.00%12 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3405      +/-   ##==========================================+ Coverage   67.21%   67.55%   +0.33%==========================================  Files         220      293      +73       Lines       45629    63810   +18181     ==========================================+ Hits        30671    43107   +12436- Misses      14958    20703    +5745
FlagCoverage Δ
addons92.58% <ø> (?)
netcore72.47% <39.68%> (?)
netfx66.22% <39.06%> (-1.00%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commit12f742d intomainJun 20, 2025
251 checks passed
@benrr101benrr101 deleted the dev/russellben/merge/sqlbulkcopy branchJune 20, 2025 17:02
@paulmedynskipaulmedynski added this to the6.1-preview2 milestoneJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edwardnealedwardnealedwardneal left review comments

Copilot code reviewCopilotCopilot left review comments

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@benrr101@mdaigle@paulmedynski@edwardneal
[8]ページ先頭
©2009-2025 Movatter.jp