Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add ChannelDbConnectionPool stub and unit tests.#3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdaigle merged 1 commit intomainfromdev/mdaigle/channel-connection-pool
Jun 6, 2025

Conversation

mdaigle
Copy link
Contributor

Description

Adds a class for the new connection pool. Adds unit tests for the class to ensure exceptions are thrown as expected.

Issues

#3356

Testing

Added unit tests.

Guidelines

Please review the contribution guidelines before submitting a pull request:

@mdaiglemdaigle requested a review froma team as acode ownerJune 5, 2025 16:38
@mdaiglemdaigle changed the titleAdd ChannelDbConnectionPool and unit tests.Add ChannelDbConnectionPool stub and unit tests.Jun 5, 2025
Base automatically changed fromadd-unit-test-project tomainJune 5, 2025 19:13
@mdaiglemdaigleforce-pushed thedev/mdaigle/channel-connection-pool branch fromb8a5318 to8f11e53CompareJune 5, 2025 19:16
@mdaiglemdaigleforce-pushed thedev/mdaigle/channel-connection-pool branch 2 times, most recently from585a12b to6b59d91CompareJune 5, 2025 20:49
@mdaiglemdaigleforce-pushed thedev/mdaigle/channel-connection-pool branch from6b59d91 to12c7aa8CompareJune 5, 2025 20:52
@codecovCodecov
Copy link

codecovbot commentedJun 5, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.93%. Comparing base(835bf30) to head(12c7aa8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3396      +/-   ##==========================================+ Coverage   64.59%   65.93%   +1.34%==========================================  Files         300      301       +1       Lines       65603    65625      +22     ==========================================+ Hits        42375    43272     +897+ Misses      23228    22353     -875
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore72.30% <100.00%> (+3.72%)⬆️
netfx63.83% <100.00%> (-1.83%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cheenamalhotracheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Considering this is just scaffolding as of now - and will be implemented later.

Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep, no problems here. Looking forward to implementation and more test cases when implementation is added.

mdaigle reacted with hooray emoji
@mdaiglemdaigle merged commit0444198 intomainJun 6, 2025
251 checks passed
@mdaiglemdaigle deleted the dev/mdaigle/channel-connection-pool branchJune 6, 2025 22:30
@paulmedynskipaulmedynski added this to the6.1-preview2 milestoneJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@mdaigle@benrr101@cheenamalhotra@paulmedynski
[8]ページ先頭
©2009-2025 Movatter.jp