NotificationsYou must be signed in to change notification settings
Fork311
Star927

Merge | SqlAppContextSwitchManager#3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

benrr101 merged 7 commits intomainfromdev/russellben/merge/appcontextswitchmanager

Jun 23, 2025

Merged

Merge | SqlAppContextSwitchManager#3389

benrr101 merged 7 commits intomainfromdev/russellben/merge/appcontextswitchmanager

Jun 23, 2025

Conversation

Copy link

Contributor

benrr101 commentedJun 3, 2025

Description

Very simple PR, SqlAppConextSwitchManager was moved into common project, suffix changed from NetCoreApp to netcore. File was wrapped in #if NET. Required package reference was added to common project, and I took the opportunity to clean up the item groups a bit.

Issues

More work towards#1261

Testing

Just moving stuff around, CI should provide validation.

benrr101 added3 commits

June 3, 2025 18:24

Move context switch manager into common project

48530c1

Wrap in #if NET

b452941

Cleanup package references in common project

Gotta keep stuff alphabetical

d1950eb

CopilotAI review requested due to automatic review settings

June 3, 2025 23:38

benrr101 added the Common Project 🚮Things that relate to the common project project label

Jun 3, 2025

benrr101 requested a review froma team as acode owner

June 3, 2025 23:38

CopilotAI reviewed

Jun 3, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR moves the SqlAppContextSwitchManager file into the common project, renames its suffix from "NetCoreApp" to "netcore", and wraps the file in a conditional compilation block. It also updates the project files to clean up item groups and adjust references based on the target framework.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAppContextSwitchManager.netcore.cs	Added a "#if NET" wrapper around the file.
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj	Reorganized and updated references and package items for better clarity and framework separation.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj	Updated compile includes to reference the newly located file and removed the old file reference.

Copy link

codecovbot commentedJun 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base(12f742d) to head(250c1f4).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #3389      +/-   ##==========================================- Coverage   63.51%   62.17%   -1.34%==========================================  Files         293      291       -2       Lines       63810    63677     -133     ==========================================- Hits        40526    39592     -934- Misses      23284    24085     +801