- Notifications
You must be signed in to change notification settings - Fork311
Fix sequential text reader bug and add covering test#3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
/azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSequentialTextReader.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor simplicity suggestion.
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
/azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
97be747 intodotnet:mainUh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3383 +/- ##==========================================- Coverage 67.04% 0 -67.05%========================================== Files 300 0 -300 Lines 65376 0 -65376 ==========================================- Hits 43831 0 -43831+ Misses 21545 0 -21545
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes#3361
When using single byte input the test provided triggered a condition where the next read would skip data in available internal buffer because it was exactly, and not less than, the required amount.
/cc@m0a0k0s