My last PR ran as a forked build and so missed some tests that use reflection to access pool properties. This PR corrects the issue and runs as a branch build to ensure full coverage.

Issues

Fixes test failures due to#3352

Testing

Runs full test suite (including branch-build-only tests)

Guidelines

Please review the contribution guidelines before submitting a pull request:

Access auth contexts as public param.

2fd3001

CopilotAI review requested due to automatic review settings

May 27, 2025 18:04

mdaigle requested a review froma team as acode owner

May 27, 2025 18:04

CopilotAI reviewed

May 27, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes issues with test failures by correcting the reflection usage to access pool properties in authentication tests.

Changed reflection binding flags for "AuthenticationContexts" from non-public to public.
Ensured that tests now correctly access the intended property using the updated API.

Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Common/SystemDataInternals/FedAuthTokenHelper.cs:99

The change from BindingFlags.NonPublic to BindingFlags.Public indicates an adjustment to access a now public member. Please confirm that this update aligns with the overall API design and that any related documentation has been updated accordingly.

IEnumerable authenticationContexts = (IEnumerable)databaseConnectionPoolObj.GetType().GetProperty("AuthenticationContexts", BindingFlags.Public | BindingFlags.Instance).GetValue(databaseConnectionPoolObj, null);

Copy link

codecovbot commentedMay 27, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.45%. Comparing base(b8948f2) to head(2fd3001).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #3379      +/-   ##==========================================- Coverage   67.04%   64.45%   -2.59%==========================================  Files         300      298       -2       Lines       65376    65525     +149     ==========================================- Hits        43831    42236    -1595- Misses      21545    23289    +1744