Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

avoid some allocations when opening a connection#3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cheenamalhotra merged 4 commits intodotnet:mainfromErikEJ:issue-3363
May 26, 2025

Conversation

ErikEJ
Copy link
Contributor

fixes#3363

vonzshik, mdaigle, edwardneal, and 0xfeeddeadbeef reacted with hooray emoji
@CopilotCopilotAI review requested due to automatic review settingsMay 20, 2025 13:03
@ErikEJErikEJ requested a review froma team as acode ownerMay 20, 2025 13:03
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR reduces runtime allocations by pre-building arrays of Azure SQL endpoint strings and refactoring theIsEndpoint helper to use these arrays instead of concatenating prefixes on each check.

  • Introducess_azureSqlServerOnDemandEndpoints for on-demand endpoints.
  • ChangesIsEndpoint to accept astring[] of endpoints.
  • Updates calls inIsAzureSynapseOnDemandEndpoint andIsAzureSqlServerEndpoint to use the new arrays.
Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs:781

  • Add unit tests covering each value ins_azureSqlServerOnDemandEndpoints to verify thatIsAzureSynapseOnDemandEndpoint correctly recognizes all intended on-demand endpoints.
internal static readonly string[] s_azureSqlServerOnDemandEndpoints = { ONDEMAND_PREFIX + AZURE_SQL,

Copy link
Contributor

@paulmedynskipaulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great efficiency win. Just a couple of comments.

@ErikEJ
Copy link
ContributorAuthor

@paulmedynski Comments addressed

paulmedynski
paulmedynski previously approved these changesMay 20, 2025
Copy link
Contributor

@paulmedynskipaulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

@ErikEJ
Copy link
ContributorAuthor

Thanks@vonzshik !

@paulmedynski Possible to get CI running?

vonzshik reacted with thumbs up emoji

@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedMay 20, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.39%. Comparing base(6d2473d) to head(3953e73).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3364      +/-   ##==========================================- Coverage   65.10%   61.39%   -3.72%==========================================  Files         300      294       -6       Lines       65376    65071     -305     ==========================================- Hits        42565    39949    -2616- Misses      22811    25122    +2311
FlagCoverage Δ
addons?
netcore66.55% <100.00%> (-1.77%)⬇️
netfx59.66% <100.00%> (-6.68%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErikEJ
Copy link
ContributorAuthor

@cheenamalhotra@paulmedynski PR updated

@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

paulmedynski
paulmedynski previously approved these changesMay 20, 2025
@Wraith2
Copy link
Contributor

@ErikEJ
Copy link
ContributorAuthor

@Wraith2 Thanks, tests (and bugs) fixed.
@edwardneal PR updated

edwardneal reacted with hooray emoji

@ErikEJ
Copy link
ContributorAuthor

@cheenamalhotra@paulmedynski Could you please help with CI?

@cheenamalhotra
Copy link
Member

/azp run

ErikEJ reacted with heart emoji

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotracheenamalhotra added this to the6.1-preview2 milestoneMay 21, 2025
@ErikEJErikEJ requested a review frompaulmedynskiMay 21, 2025 15:00
@cheenamalhotracheenamalhotra merged commit1b07f8b intodotnet:mainMay 26, 2025
237 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edwardnealedwardnealedwardneal left review comments

Copilot code reviewCopilotCopilot left review comments

@Wraith2Wraith2Wraith2 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

Reduce IsAzureSynapseOnDemandEndpoint allocations
5 participants
@ErikEJ@paulmedynski@cheenamalhotra@Wraith2@edwardneal
[8]ページ先頭
©2009-2025 Movatter.jp