Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Merge references to PacketHandle#3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

edwardneal
Copy link
Contributor

Relates to#1261.

This picks up the work left dangling by#3353; that PR needs to be merged first.

There are a lot of small methods which use the PacketHandle definition merged by the prerequisite PR. The methodology is fairly easy to review commit-by-commit fromfc3c31e onwards.

This also allows _writePacketCache to be migrated to TdsParserStateObjectNative in netfx.
@edwardnealedwardneal marked this pull request as ready for reviewMay 23, 2025 20:16
@edwardnealedwardneal requested a review froma team as acode ownerMay 23, 2025 20:16
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedMay 26, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is90.27778% with7 lines in your changes missing coverage. Please review.

Project coverage is 59.62%. Comparing base(b8948f2) to head(bd5a153).
Report is 17 commits behind head on main.

Files with missing linesPatch %Lines
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs92.45%4 Missing⚠️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs80.00%3 Missing⚠️

❗ There is a different number of reports uploaded between BASE (b8948f2) and HEAD (bd5a153). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (b8948f2)HEAD (bd5a153)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3355      +/-   ##==========================================- Coverage   67.04%   59.62%   -7.43%==========================================  Files         300      292       -8       Lines       65376    65191     -185     ==========================================- Hits        43831    38867    -4964- Misses      21545    26324    +4779
FlagCoverage Δ
addons?
netcore62.93% <80.00%> (-9.27%)⬇️
netfx60.90% <92.98%> (-4.29%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotracheenamalhotra requested a review froma teamMay 27, 2025 17:28
Copy link
Contributor

@mdaiglemdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thank you!

@mdaigle
Copy link
Contributor

A lot of our builds got throttled last week. I kicked the cancelled job.

edwardneal reacted with rocket emoji

@benrr101benrr101 merged commita166e54 intodotnet:mainJun 4, 2025
237 checks passed
@edwardnealedwardneal deleted the merge/packethandle-follow-up branchJune 5, 2025 05:12
@paulmedynskipaulmedynski added this to the6.1-preview2 milestoneJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@edwardneal@paulmedynski@mdaigle@benrr101
[8]ページ先頭
©2009-2025 Movatter.jp