Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | DbConnectionOptions Prep Work#3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 13 commits intomainfromdev/russellben/merge/dbconnectionoptions-debug
May 29, 2025

Conversation

benrr101
Copy link
Contributor

Description: This one does some misc work before merging the netfx and netcore DbConnectionOptions partials into the existing DbConnectionOptions class. I could probably just merge it all together in one PR, but it feels like this should be its own PR.

  • Rename DbConnectionOptions.Common to DbConnectionOptions
  • Rename platform specific DbConnectionOptions partials to DbConnectionOptions.[netfx|netcore]
  • Move DbConnectionOptions (and partials) to the ConnectionString namespace
  • Separate debug code in DbConnectionOptions into its own partial
  • Remove the KEY and SYNONYM internal static classes from the DbConnectionOptions and replace them with usages of DbConnectionKeywords and DbConnectionSynonyms

Testing: Everything still builds and should pass tests

@benrr101benrr101 added this to the6.1-preview2 milestoneMay 12, 2025
@benrr101benrr101 requested a review froma teamMay 12, 2025 16:43
@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelMay 12, 2025
@codecovCodecov
Copy link

codecovbot commentedMay 12, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is68.57143% with11 lines in your changes missing coverage. Please review.

Project coverage is 64.46%. Comparing base(1eabf80) to head(62f2e4d).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
...mmon/ConnectionString/DbConnectionOptions.Debug.cs0.00%8 Missing⚠️
...ata/Common/ConnectionString/DbConnectionOptions.cs90.47%2 Missing⚠️
...mmon/ConnectionString/DbConnectionOptions.netfx.cs83.33%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3343      +/-   ##==========================================- Coverage   64.47%   64.46%   -0.02%==========================================  Files         298      299       +1       Lines       65525    65525              ==========================================- Hits        42248    42239       -9- Misses      23277    23286       +9
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore68.54% <65.51%> (+0.03%)⬆️
netfx65.31% <68.57%> (-0.06%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski
paulmedynski previously approved these changesMay 12, 2025
…Keywords and DbConnectionStringSynonymsSome light cleanup for nearby code
…fx suffixChange reference to common project DbConnectionOptions.cs
…etcore suffixChange reference to common project DbConnectionOptions.cs
@benrr101benrr101force-pushed thedev/russellben/merge/dbconnectionoptions-debug branch from485976b tod6b1244CompareMay 12, 2025 22:31
mdaigle
mdaigle previously approved these changesMay 16, 2025
paulmedynski
paulmedynski previously approved these changesMay 22, 2025
# Conflicts:#src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPool.cs#src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolGroup.cs
@benrr101benrr101 merged commit072f318 intomainMay 29, 2025
251 checks passed
@benrr101benrr101 deleted the dev/russellben/merge/dbconnectionoptions-debug branchMay 29, 2025 18:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

3 participants
@benrr101@mdaigle@paulmedynski
[8]ページ先頭
©2009-2025 Movatter.jp