Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup | Interop Path Links#3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 3 commits intomainfromdev/russellben/fix-netcore-interop-paths
May 12, 2025

Conversation

benrr101
Copy link
Contributor

Description: Very small 🥔🥔, but it was driving me crazy once I saw it. Basically, some of the interop files in the netcore project had paths that were doubly nested. This PR removes those doubly nested paths.

ie:
Interop\Windows\NtDll\Interop\Windows\NtDll\file.cs
becomes
Interop\Windows\Ntdll\file.cs

This also fixes a mistake for ObjectAttributeFlags. Both ObjectAttributes and ObjectAttributeFlags were being linked as "ObjectAttributes". Fixed that as well.

edwardneal reacted with thumbs up emoji
@benrr101benrr101 added this to the6.1-preview2 milestoneMay 8, 2025
@benrr101benrr101 requested a review froma teamMay 8, 2025 22:50
@benrr101benrr101 added the Code Health 💊Issues/PRs that are targeted to source code quality improvements. labelMay 8, 2025
@benrr101benrr101 changed the titleCleanup |Cleanup | Interop Path LinksMay 8, 2025
Co-authored-by: Edward Neal <55035479+edwardneal@users.noreply.github.com>
@codecovCodecov
Copy link

codecovbot commentedMay 9, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base(14bee54) to head(83108cc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3338      +/-   ##==========================================- Coverage   65.07%   64.29%   -0.78%==========================================  Files         298      298                Lines       65515    65517       +2     ==========================================- Hits        42634    42126     -508- Misses      22881    23391     +510
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore68.36% <ø> (+0.02%)⬆️
netfx65.02% <ø> (-1.15%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commit1aba9e3 intomainMay 12, 2025
251 checks passed
@benrr101benrr101 deleted the dev/russellben/fix-netcore-interop-paths branchMay 12, 2025 22:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edwardnealedwardnealedwardneal left review comments

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@benrr101@mdaigle@paulmedynski@edwardneal
[8]ページ先頭
©2009-2025 Movatter.jp