NotificationsYou must be signed in to change notification settings
Fork311
Star927

Refine handling of moving between replay and continue states#3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cheenamalhotra merged 3 commits intodotnet:mainfromWraith2:fix-3336

May 26, 2025

Merged

Refine handling of moving between replay and continue states#3337

cheenamalhotra merged 3 commits intodotnet:mainfromWraith2:fix-3336

May 26, 2025

Conversation

Copy link

Contributor

Wraith2 commentedMay 7, 2025

fixes#3336

Refines moving between ReplayRunning and ContinueRunning states fixing an issue with varbinary reads.

Copy link

Member

cheenamalhotra commentedMay 7, 2025

/azp run

Copy link

azure-pipelinesbot commentedMay 7, 2025

Azure Pipelines successfully started running 2 pipeline(s).

cheenamalhotra added this to the6.1-preview2 milestone

May 7, 2025

Copy link

codecovbot commentedMay 8, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is59.45946% with15 lines in your changes missing coverage. Please review.

Project coverage is 59.54%. Comparing base(b8948f2) to head(6485691).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	0.00%	5 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	0.00%	5 Missing⚠️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs	78.26%	5 Missing⚠️

❗ There is a different number of reports uploaded between BASE (b8948f2) and HEAD (6485691). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (b8948f2) HEAD (6485691)
addons 1 0

Additional details and impacted files

@@            Coverage Diff             @@##             main    #3337      +/-   ##==========================================- Coverage   67.04%   59.54%   -7.51%==========================================  Files         300      293       -7       Lines       65376    65077     -299     ==========================================- Hits        43831    38749    -5082- Misses      21545    26328    +4783

Flag	Coverage Δ
addons	`?`
netcore	`62.85% <68.75%> (-9.34%)`	⬇️
netfx	`60.79% <68.75%> (-4.40%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

ContributorAuthor

Wraith2 commentedMay 9, 2025

The CI failures are caused by nuget timeouts.
I'll need this merged to build on it and fix#3331

This was referencedMay 11, 2025

SqlClient 6.0.1 DataReader hangs on trying to read 1 row with 150Mb value in nvarchar(max) column - consume huge amount of memory, and do not react to cancelationToken#3274

Closed

6.1 Preview 1: SqlDataReader.GetChars ignoring BufferIndex?#3331

Closed

refine handling of moving between replay and continue states

494a600

Wraith2 force-pushed thefix-3336 branch fromee20e36 to494a600Compare

May 20, 2025 19:35

Wraith2 requested a review froma team as acode owner

May 20, 2025 19:35

Copy link

ContributorAuthor

Wraith2 commentedMay 20, 2025

Can I get CI and review on this please? There are further fixes waiting that build on this one.

Copy link

Contributor

azure-pipelinesbot commentedMay 20, 2025

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

ContributorAuthor

Wraith2 commentedMay 20, 2025

I'm not sure if the CI is having problems or there is a real issue with the code.

Copy link

Contributor

mdaigle commentedMay 21, 2025

It looks like one job timed out, but everything else succeeded. I kicked that one job.

mdaigle requested changes

May 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs OutdatedShow resolvedHide resolved

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCachedBuffer.cs OutdatedShow resolvedHide resolved

address review feedback

24f6d46

Copy link

ContributorAuthor

When I looked (and subsequently commented) the CI had been running for 3 hours without either timing our or completing so i was concerned that I'd introduced a hanging behaviour. If it managed to complete then I haven't

Can you start the CI please.