Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | SqlDataSourceEnumerator.Unix.cs#3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

benrr101
Copy link
Contributor

Description: Quick and easy PR, moving the SqlDataSourceEnumerator.Unix.cs file from the netcore project to the common project. It was renamed to SqlDataSourceEnumerator.netcore.Unix.cs to follow the pattern I've been using.

Also renamed SqlDataSourceEnumeratorManagedHelper.cs to SqlDataSourceEnumeratorManagedHelper.netcore.cs to indicate it is only used in the netcore project. The class was also wrapped in an#if NET

Testing: Project still builds locally, there were no functional changes to the code.

@benrr101benrr101 added this to the6.1-preview2 milestoneMay 7, 2025
@benrr101benrr101 requested a review froma teamMay 7, 2025 17:36
@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelMay 7, 2025
@codecovCodecov
Copy link

codecovbot commentedMay 8, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.98%. Comparing base(14bee54) to head(6a472c0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3335      +/-   ##==========================================+ Coverage   65.07%   66.98%   +1.90%==========================================  Files         298      298                Lines       65515    65515              ==========================================+ Hits        42634    43884    +1250+ Misses      22881    21631    -1250
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore72.17% <ø> (+3.83%)⬆️
netfx65.02% <ø> (-1.15%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commitec8ca55 intomainMay 12, 2025
251 checks passed
@benrr101benrr101 deleted the dev/russellben/merge/sqldatasourceenumerator-unix branchMay 12, 2025 22:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

3 participants
@benrr101@mdaigle@paulmedynski
[8]ページ先頭
©2009-2025 Movatter.jp