Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

set NeutralLanguage in AssemblyInfo.props#3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 1 commit intodotnet:mainfromBradBarnich:generate-neutral-lang
May 5, 2025

Conversation

BradBarnich
Copy link
Contributor

a potential fix for#3324

as described in the linked issue, it was intended to be there in the netfx build but was lost in the sdk csproj conversion

I'm not very familiar with resources, but it seems like it should be emitted for both netfx and net core builds.

@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra
Copy link
Member

cheenamalhotra commentedMay 2, 2025•
edited
Loading

Thanks for finding and addressing the issue@BradBarnich , I agree this is necessary, and believe that must have been an oversight in the commit you attached in the issue.

BradBarnich reacted with thumbs up emoji

@cheenamalhotracheenamalhotra requested a review froma teamMay 2, 2025 22:42
@cheenamalhotracheenamalhotra added this to the6.1-preview2 milestoneMay 2, 2025
@benrr101benrr101 merged commit41a5358 intodotnet:mainMay 5, 2025
237 checks passed
@codecovCodecov
Copy link

codecovbot commentedMay 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base(965e5ff) to head(1973a13).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (965e5ff) and HEAD (1973a13). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (965e5ff)HEAD (1973a13)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3325      +/-   ##==========================================- Coverage   67.74%   62.20%   -5.54%==========================================  Files         298      292       -6       Lines       65536    65226     -310     ==========================================- Hits        44397    40574    -3823- Misses      21139    24652    +3513
FlagCoverage Δ
addons?
netcore66.57% <ø> (-5.57%)⬇️
netfx60.63% <ø> (-5.53%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@David-EngelDavid-EngelDavid-Engel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@BradBarnich@cheenamalhotra@David-Engel@benrr101
[8]ページ先頭
©2009-2025 Movatter.jp