- Notifications
You must be signed in to change notification settings - Fork311
Merge | SqlInternalConnectionTds preparation#3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merge | SqlInternalConnectionTds preparation#3323
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…perty.netcore: synced explicit variable type in declaration.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks pretty good to me, my only comments are probably out of scope since the overall goal is to align the two codebases, not necessarily clean them up. Feel free to address or ignore and comment on my comments.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedMay 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3323 +/- ##===========================================- Coverage 75.42% 62.15% -13.28%=========================================== Files 262 292 +30 Lines 41241 65263 +24022 ===========================================+ Hits 31106 40562 +9456- Misses 10135 24701 +14566
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for looking at the comments - looking forward to getting this merged 🚀 🚢
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
dc1298a
intodotnet:mainUh oh!
There was an error while loading.Please reload this page.
This contains the preparatory work for the merge of SqlInternalConnectionTds. We're working with a smaller code file here, so I've merged every part of the two files which avoids a behavioural change.
This should be easier to review comment-by-comment - it's bulky, but not complex. I'd also appreciate a CI run.
At the end of this, the diff is +43/-80. Remaining differences here are:
What should we do with Transparent Network IP Resolution? This functionality doesn't exist in netcore at all - does it need to be ported? If it only exists in netfx for backwards compatibility, should it be made obsolete?
I'd also be interested to know what the right style of exception messages is. If (for example) the connection receives an unexpected session recovery feature extension acknowledgement, which exception message should I merge in favour of?
The former is netfx, the latter is netcore. I prefer the detail of netfx, but I imagine netcore changed this for a reason.