- Notifications
You must be signed in to change notification settings - Fork311
Merge | SqlFileStream.Unix#3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR consolidates the unsupported SqlFileStream implementation by moving it from its previous location into a new file (SqlFileStream.netcore.Unix.cs) and updating its formatting to use expression-bodied members, with conditional compilation applied via #if NET.
- Renamed and relocated the unsupported SqlFileStream implementation for Unix.
- Updated documentation reference paths and applied expression-bodied syntax for consistency.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlTypes/SqlFileStream.netcore.Unix.cs | Implements the Unix-specific unsupported SqlFileStream with updated formatting and documentation integration. |
| src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlFileStream.Unsupported.cs | Removed to consolidate the unsupported implementation into the common project. |
Files not reviewed (1)
- src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj: Language not supported
codecovbot commentedApr 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3306 +/- ##==========================================- Coverage 72.97% 72.94% -0.04%========================================== Files 298 298 Lines 57002 57003 +1 ==========================================- Hits 41600 41578 -22- Misses 15402 15425 +23
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
965e5ff intomainUh oh!
There was an error while loading.Please reload this page.
Description: Another easy one, moving the SqlFileStream.Unsupported to the common project. In this instance, the file was renamed to SqlFileStream.netcore.Unix, wrapped in a
#if NET, the documentation links were fixed, and the formatting was spaced out a bit (and changed to expression bodies)Testing: File moved, it's just throws unsupported exceptions, nothing super important is happening.