- Notifications
You must be signed in to change notification settings - Fork311
Tests | Activate "ActiveIssue" tests#3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Move tests around to TestSet when necessary, consolidate AE test sets
Co-authored-by: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Factor out tests that have different conditions
4708a72 tob5005bcCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Duplicate method breaking compilation.
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Just an update on this one - I'm running into one of the tests causing hanging after the tests complete. This seems to happen locally without the test even running. On debug, the check for azure synapse seems to be happening in a loop, so I'm trying to investigate what's causing that. |
/azp run |
| Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
@benrr101 - Can you resolve the conflicts here? I think this is ready to merge otherwise. |
# Conflicts:#src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CspProviderExt.cs#src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
This is a recreation of#3012 to resolve merges, rebase it off of main, and enable full CI builds. Original description is below
This PR activates a couple of tests that were marked with "ActiveIssue"
Upon trying them out, they seem to run fine.
Also does some minor improvements on a few tests or disable some tests on specific platform
Fixes#3035
This also fixes and allows to close the following ActiveIssue's in AzDO: