- Notifications
You must be signed in to change notification settings - Fork311
Complete removal of SQL 2000 support#3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…helZ/SqlClient into pr/tdsparser-remove-sql-2000
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionSmi.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good - one small change requested.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| finally | ||
| { | ||
| if (con != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add braces here, or use null-conditionalcon?.Dispose() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes - fixed. I've updated the netcore code to keep it in sync.
/azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
codecovbot commentedMar 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3217 +/- ##==========================================- Coverage 72.58% 66.14% -6.44%========================================== Files 289 282 -7 Lines 59503 59203 -300 ==========================================- Hits 43188 39162 -4026- Misses 16315 20041 +3726
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e04631 intodotnet:mainUh oh!
There was an error while loading.Please reload this page.
This finishes the work from#3206 and prior PRs. It removes the
Is2005OrNewerandIs2000properties fromSqlCommand,SqlConnection,SqlInternalConnectionSmi,SqlInternalConnectionTds,SqlInternalConnectionandTdsParser, then chases those references through the codebase.I'd appreciate a CI run against this, although I don't think there'll be any surprises here - all of these code paths should be dead.