Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Cleanup Pre 2005 Support in TdsParser#3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 8 commits intomainfromdev/russellben/mz-pre2005-cleanup
Mar 11, 2025

Conversation

benrr101
Copy link
Contributor

Rebuilding#3085 under the dotnet repo in order to complete full CI, original description is as follows

Now that#2839 is merged, the Pre 2005 Code can be removed from netfx to align netfx & netcore code for future merge of TdsParser.

It also removes asserts that were used to gate 2005-only code

The code does not aim to remove Pre 2005 Code from other classes

This is working towards#2953

@benrr101benrr101 added Code Health 💊Issues/PRs that are targeted to source code quality improvements. Common Project 🚮Things that relate to the common project project labelsMar 7, 2025
@benrr101benrr101 added this to the7.0-preview1 milestoneMar 7, 2025
@benrr101benrr101 requested a review froma teamMarch 7, 2025 01:01
- Removing _is2005- Removing ENV_CHANGE types that are not supported in TDS >7
@codecovCodecov
Copy link

codecovbot commentedMar 8, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base(87b5435) to head(2a54720).
Report is 43 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@##             main    #3206       +/-   ##===========================================+ Coverage   72.57%   92.58%   +20.00%===========================================  Files         288        6      -282       Lines       59526      310    -59216     ===========================================- Hits        43201      287    -42914+ Misses      16325       23    -16302
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore?
netfx?

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commitcb4f568 intomainMar 11, 2025
252 checks passed
@benrr101benrr101 deleted the dev/russellben/mz-pre2005-cleanup branchMarch 11, 2025 20:11
Wraith2 pushed a commit to Wraith2/SqlClient that referenced this pull requestMar 11, 2025
* Cleanup Pre 2005 Support in TdsParser* Fix some code indentation issues* Fix some code indentation issues* Add back isVersion8* PR Comments- Removing _is2005- Removing ENV_CHANGE types that are not supported in TDS >7---------Co-authored-by: Michel Zehnder <MichelZ@users.noreply.github.com>Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
@cheenamalhotracheenamalhotra added the Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver. labelApr 16, 2025
@cheenamalhotracheenamalhotra removed the Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver. labelApr 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edwardnealedwardnealedwardneal left review comments

@mdaiglemdaiglemdaigle approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

6 participants
@benrr101@mdaigle@cheenamalhotra@paulmedynski@edwardneal@MichelZ
[8]ページ先頭
©2009-2025 Movatter.jp