NotificationsYou must be signed in to change notification settings
Fork311
Star927

SqlBulkCopy: Explicitly state column name that mismatches(#3170)#3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

paulmedynski merged 1 commit intodotnet:mainfromJNjenga:main

Mar 5, 2025

Merged

SqlBulkCopy: Explicitly state column name that mismatches(#3170)#3183

paulmedynski merged 1 commit intodotnet:mainfromJNjenga:main

Mar 5, 2025

Conversation

Copy link

Contributor

JNjenga commentedFeb 26, 2025

ThrowingSQL.BulkLoadNonMatchingColumnMapping exception when column mappings mismatch does not provide enough information about where the error occurred. ThrowingSQL.BulkLoadNonMatchingColumnName exception is more appropriate.

Fixes (#3170)

Copy link

ContributorAuthor

JNjenga commentedFeb 26, 2025

@dotnet-policy-service agree

campersau reviewed

Feb 27, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs OutdatedShow resolvedHide resolved

paulmedynski requested a review froma team

February 27, 2025 17:13

paulmedynski reviewed

Feb 27, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs OutdatedShow resolvedHide resolved

paulmedynski reviewed

Feb 27, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnMapping.cs OutdatedShow resolvedHide resolved

paulmedynski reviewed

Feb 27, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs Outdated


		if(!columnMapping._matchedOrRejected)
		{
		throw (SQL.BulkLoadNonMatchingColumnName(columnMapping.SourceColumn));

Copy link

Contributor

paulmedynskiFeb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does changing fromSQL.BulkLoadNonMatchingColumnMapping() toSQL.BulkLoadNonMatchingColumnName() affect our API promises? They both end up throwing InvalidOperationException, so probably not. Callers shouldn't be depending on the message of the exception, but you never know!