Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix synonym count issues on debug#3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cheenamalhotra merged 1 commit intomainfromdev/cheena/fix-synonym-count
Jan 8, 2025

Conversation

cheenamalhotra
Copy link
Member

Addresses#3016 due to deprecated keywords count mismatch..
This change is more effective for unit testing than#3088, hence proposing the same.

The deprecated keywords weren't tracked before, and this PR removes the counter. If keywords are needed to be deprecated, we can deprecate them on docs and follow deprecation path in future releases. We need not manage counters to be modified as they are very sensitive to changes and affect unit testing in debug mode.

edwardneal reacted with hooray emoji
@cheenamalhotracheenamalhotra requested review frompaulmedynski anda teamJanuary 8, 2025 13:38
@cheenamalhotra
Copy link
MemberAuthor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cheenamalhotracheenamalhotra changed the titleFis synonym count issues on debugFix synonym count issues on debugJan 8, 2025
@cheenamalhotracheenamalhotra merged commitd8d9fc4 intomainJan 8, 2025
128 of 130 checks passed
@cheenamalhotracheenamalhotra deleted the dev/cheena/fix-synonym-count branchJanuary 8, 2025 15:20
@cheenamalhotracheenamalhotra linked an issueJan 8, 2025 that may beclosed by this pull request
@codecovCodecov
Copy link

codecovbot commentedJan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base(7d93424) to head(ee34563).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3098      +/-   ##==========================================- Coverage   72.76%   72.76%   -0.01%==========================================  Files         283      283                Lines       58968    58996      +28     ==========================================+ Hits        42908    42926      +18- Misses      16060    16070      +10
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.51% <100.00%> (+0.02%)⬆️
netfx71.22% <100.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@mdaiglemdaigle added this to the7.0-preview1 milestoneJan 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@apoorvdeshmukhapoorvdeshmukhapoorvdeshmukh approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

Debug Assertion Failure : incorrect initial ParseSynonyms size
4 participants
@cheenamalhotra@apoorvdeshmukh@paulmedynski@mdaigle
[8]ページ先頭
©2009-2025 Movatter.jp