Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP/Tests | Widen test code coverage#3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
edwardneal wants to merge8 commits intodotnet:main
base:main
Choose a base branch
Loading
fromedwardneal:tests/test-coverage-1

Conversation

edwardneal
Copy link
Contributor

WIP - running this through CI and Codecov to make sure my local coverage figures align.

This PR ensures that the public API surface for SqlDataRecord and SqlMetaData are covered by tests. It also expands coverage of some of the basic data validation on SqlParameter and SqlCommand.

@ErikEJ
Copy link
Contributor

@edwardneal Did you look at the code coverage report for "inspiration" ?

@edwardneal
Copy link
ContributorAuthor

I did; Codecov aligns with it:

The code coverage for SqlDataRecord is currently ~75%, where I expect this PR will bring it to close to 100% in the code coverage report. The code paths which aren't covered are ones which can't ever be called and are due to be removed; once that happens I expect these two files will hit 100%.

SqlParameter is a much larger class, and it's got a custom TypeConverter which doesn't appear to have test coverage. I've added a few tests for basic validation, but the class will need more work here.

@edwardneal
Copy link
ContributorAuthor

@mdaigle would you mind triggering the Azure Pipelines bot please? It looks like CI has stopped triggering on my PRs.

mdaigle reacted with thumbs up emoji

@mdaigle
Copy link
Contributor

/azp run

edwardneal reacted with thumbs up emoji

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@edwardneal
Copy link
ContributorAuthor

Thanks. It looks like there's a slightly deeper problem with CI - the Password and the Azure_Password variables (and maybe other secret variables?) aren't being substituted.

@mdaigle
Copy link
Contributor

Thanks. It looks like there's a slightly deeper problem with CI - the Password and the Azure_Password variables (and maybe other secret variables?) aren't being substituted.

Yeah, I need to dig into this further. We had a security action item to limit forked build access to pipeline secrets and I think the trigger was pulled on that before we made accommodating changes. There's a general trend toward locked down permissions for forked builds. We need to start updating tests to use dynamically generated (rather than static) resources so that we don't rely on pipeline secrets.

@David-Engel started doing some work in this direction with#2750. I bumped the pipeline there to see if mac tests are passing with those changes.

@mdaigle
Copy link
Contributor

/azp run

@benrr101
Copy link
Contributor

@edwardneal Sorry to take so long to get to this one... I think I kinda just ignored it since it has "WIP" in the title. Should this PR be reviewed and attempted to be checked in yet?

@paulmedynski
Copy link
Contributor

@edwardneal - More conflicts to resolve. I'll have a look once that is done.

@edwardneal
Copy link
ContributorAuthor

Thanks@paulmedynski and@benrr101. I'm planning to move these tests into the new project (and to verify coverage for SqlBuffer at the same time) so I'll pull this back to draft for now.

@edwardnealedwardneal marked this pull request as draftJuly 10, 2025 12:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@edwardneal@ErikEJ@mdaigle@benrr101@paulmedynski

[8]ページ先頭

©2009-2025 Movatter.jp