- Notifications
You must be signed in to change notification settings - Fork311
Tests | Split MultipleResultsTest, clean up console logging#3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
43f0be1
Split MultipleResultsTest, clean up console logging
edwardneal1fcd48d
Further console logging disabled based on CI results.
edwardneal33c6cc7
Disabling TDSServer debug logging in one diagnostic test
edwardneal0c9c467
Remove CustomDeviceFlowCallback
edwardnealee43e03
Early response to code review
edwardneala896991
Merge branch 'main' into tests/console-logging
edwardneal29a3fa4
Checked use of Environment.NewLine
edwardnealf085005
Separated Assert.Throws call
edwardnealFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Early response to code review
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitee43e031f37e97c79b51a666cd3b7b2c3093ec7e
There are no files selected for viewing
22 changes: 19 additions & 3 deletions...a.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -60,9 +60,25 @@ public void ExecuteNonQuery() | ||
// ExecuteNonQuery will drain every result set, info message and exception, collating these into a single exception. | ||
SqlException exNonQuery = Assert.Throws<SqlException>(() => command.ExecuteNonQuery()); | ||
edwardneal marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
string expectedInfoMessages = | ||
$"{ResultSet2_Error}\n" + | ||
$"{ResultSet4_Error}\n" + | ||
$"{ResultSet6_Error}\n" + | ||
$"{ResultSet8_Error}\n" + | ||
$"{ResultSet10_Error}\n" + | ||
$"{ResultSet1_Message}\n" + | ||
$"{ResultSet2_Message}\n" + | ||
$"{ResultSet3_Message}\n" + | ||
$"{ResultSet4_Message}\n" + | ||
$"{ResultSet5_Message}\n" + | ||
$"{ResultSet6_Message}\n" + | ||
$"{ResultSet7_Message}\n" + | ||
$"{ResultSet8_Message}\n" + | ||
$"{ResultSet9_Message}\n" + | ||
$"{ResultSet10_Message}\n" + | ||
$"{ResultSet11_Message}"; | ||
Assert.Equal(expectedInfoMessages, exNonQuery.Message.Replace("\r\n", "\n")); | ||
Assert.Empty(messages); | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.