Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove SQL 2000 client-side debugging support#2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

edwardneal
Copy link
Contributor

Follows up#2940, removing the client-side support for SQL 2000's debugging mechanisms from netfx and aligning with netcore.

The SqlConnection diff will be easier to parse with whitespace changes disabled. I've removed the methods which enable the now-defunct debugging, theSqlDebugContext class andMEMMAP struct which they use and the PInvokes they reference. These PInvokes were the only thing innetfx\src\Microsoft\Data\Common\NativeMethods.cs, so I've deleted the file.

This isn't critical for preview3.

/cc@benrr101 - there's no need to port PInvokes from NativeMethods.cs anywhere. It's the same story for the SafeNativeMethods.cs file in the same folder.

MichelZ reacted with thumbs up emoji
This also recurses down into NativeMethods.cs, to help clean up PInvokes.
@benrr101
Copy link
Contributor

Uhhhhhhhhhhhhhhhhhhhhhhhhhhh 😅
Can I get my PR in first and you can delete whatever from it that is no longer needed?

edwardneal and MichelZ reacted with laugh emoji

@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelNov 11, 2024
@edwardneal
Copy link
ContributorAuthor

edwardneal commentedNov 11, 2024•
edited
Loading

No worries - I'll just merge back into my branch once#2997 is done.
Edit: done!

MichelZ reacted with thumbs up emoji

@codecovCodecov
Copy link

codecovbot commentedNov 13, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is50.00000% with16 lines in your changes missing coverage. Please review.

Project coverage is 72.56%. Comparing base(4052186) to head(3aeec6f).
Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs50.00%16 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2981      +/-   ##==========================================+ Coverage   72.48%   72.56%   +0.07%==========================================  Files         288      288                Lines       59493    59385     -108     ==========================================- Hits        43123    43091      -32+ Misses      16370    16294      -76
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.36% <ø> (-0.07%)⬇️
netfx71.09% <50.00%> (+0.16%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's gooooooooo delete that code!

edwardneal and MichelZ reacted with rocket emoji
@MichelZ
Copy link
Contributor

#2839 next! :)

@cheenamalhotracheenamalhotra added this to the6.0-preview3 milestoneNov 15, 2024
@cheenamalhotracheenamalhotra merged commit4a2fbae intodotnet:mainNov 15, 2024
76 checks passed
@edwardnealedwardneal deleted the remove-sqldebugging-paths branchNovember 15, 2024 22:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@David-EngelDavid-EngelDavid-Engel approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.0-preview3
Development

Successfully merging this pull request may close these issues.

5 participants
@edwardneal@benrr101@MichelZ@David-Engel@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp