Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Complete port of PR 521 to netfx#2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cheenamalhotra merged 1 commit intodotnet:mainfromedwardneal:port-521
Nov 7, 2024

Conversation

edwardneal
Copy link
Contributor

PR#521 was originally made to .NET Core, and cross-ported to .NET Framework by PR#1443. There were two lines missing from this PR, in GetValues and GetSqlValues. This PR completes that work.

MichelZ reacted with thumbs up emoji
@codecovCodecov
Copy link

codecovbot commentedNov 2, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base(9d5ca32) to head(2b282e1).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #2964      +/-   ##==========================================- Coverage   72.31%   72.30%   -0.02%==========================================  Files         288      288                Lines       59660    59660              ==========================================- Hits        43145    43138       -7- Misses      16515    16522       +7
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.40% <ø> (-0.03%)⬇️
netfx70.69% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep, looks like those two lines weren't picked up in the backport. Kinda disconcerting that it didn't break anything 🤔

Thanks for finding and making the fix!

@benrr101benrr101 added the NetFx 👈 NetCoreIssues that require porting from .NET Core to .NET Framework labelNov 4, 2024
@benrr101benrr101 added this to the6.0-preview3 milestoneNov 4, 2024
@cheenamalhotracheenamalhotra merged commit219cfdf intodotnet:mainNov 7, 2024
76 checks passed
@edwardnealedwardneal deleted the port-521 branchNovember 7, 2024 21:42
MichelZ pushed a commit to MichelZ/SqlClient that referenced this pull requestNov 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@mdaiglemdaiglemdaigle approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

Assignees
No one assigned
Labels
NetFx 👈 NetCoreIssues that require porting from .NET Core to .NET Framework
Projects
None yet
Milestone
6.0-preview3
Development

Successfully merging this pull request may close these issues.

4 participants
@edwardneal@benrr101@mdaigle@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp