Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Drop net6 support#2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdaigle merged 8 commits intodotnet:mainfrommdaigle:drop-net6-support
Oct 31, 2024
Merged

Drop net6 support#2927

mdaigle merged 8 commits intodotnet:mainfrommdaigle:drop-net6-support
Oct 31, 2024

Conversation

mdaigle
Copy link
Contributor

@mdaiglemdaigle commentedOct 25, 2024•
edited
Loading

This PR includes the minimum necessary to drop net6 support.

I have two follow up PRs planned:

  • update documentation and build guides
  • update net6 symbol checks to net8 in test and common directories and remove net6 symbol checks from the netcore directory

cheenamalhotra reacted with thumbs up emoji
@mdaiglemdaigle mentioned this pull requestOct 25, 2024
@ErikEJ
Copy link
Contributor

LGTM, I think you forgot to remove some more lines from the .nuspec file.

@ErikEJ
Copy link
Contributor

Looks like this file can be deleted now:

src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SSPI\ManagedSSPIContextProvider.cs

@edwardneal
Copy link
Contributor

It can. Almost everything beneath netcore/src/Common/System can join it, as can everything beneath netcore/src/Common/Interop/Unix, and quite a few files from netcore/src/Common/Interop/Windows. It'll also close#303 by default.

Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While this is definitely a minimal set of changes required for removing net6 support, there will be a lot of code removal required as well. If you can create an item in ado for that (and optionally assign to me), that'd be great. Any opportunity to remove derelect code is appreciated!

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

- name: netcoreVersionTestUtils
displayName: 'Netcore Version for Test Utilities'
type: object
default: net8.0
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This version is set here, but passed down through to the test util project compilation. Trying to keep this at the highest level possible so that it's easy to bump in the future without digging down in the individual jobs.

ErikEJ and cheenamalhotra reacted with thumbs up emoji
@benrr101benrr101 added this to the6.0-preview3 milestoneOct 29, 2024
@mdaiglemdaigle added the Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver. labelOct 30, 2024
@mdaiglemdaigle merged commitfc0acc0 intodotnet:mainOct 31, 2024
141 of 143 checks passed
@mdaiglemdaigle deleted the drop-net6-support branchOctober 31, 2024 15:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

Assignees
No one assigned
Labels
Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver.
Projects
None yet
Milestone
6.0-preview3
Development

Successfully merging this pull request may close these issues.

5 participants
@mdaigle@ErikEJ@edwardneal@benrr101@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp