NotificationsYou must be signed in to change notification settings
Fork311
Star927

Update dependencies#2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cheenamalhotra merged 1 commit intodotnet:mainfromcheenamalhotra:cve/update-deps

Oct 22, 2024

Merged

Update dependencies#2921

cheenamalhotra merged 1 commit intodotnet:mainfromcheenamalhotra:cve/update-deps

Oct 22, 2024

Conversation

Copy link

Member

cheenamalhotra commentedOct 22, 2024•
edited
Loading

We need a dependency on System.Text.Json to be published as we're exposing an API directly using System.Text.Json namespace.

public class SqlJson : System.Data.SqlTypes.INullable{    public SqlJson(System.Text.Json.JsonDocument jsonDoc) { }}

cc@apoorvdeshmukh @saurabh500 @David-Engel

cheenamalhotra requested review frombenrr101,apoorvdeshmukh andDavid-Engel

October 22, 2024 19:55

Update dependencies

5f98a59

cheenamalhotra force-pushed thecve/update-deps branch fromb8b36f4 to5f98a59Compare

October 22, 2024 20:07

cheenamalhotra requested a review fromdeepaksa1

October 22, 2024 20:07

cheenamalhotra added this to the6.0-preview2 milestone

Oct 22, 2024

David-Engel approved these changes

Oct 22, 2024

View reviewed changes

Copy link

codecovbot commentedOct 22, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base(2f0de19) to head(5f98a59).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #2921      +/-   ##==========================================- Coverage   71.88%   71.87%   -0.01%==========================================  Files         294      294                Lines       60253    60338      +85     ==========================================+ Hits        43311    43368      +57- Misses      16942    16970      +28