Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

SqlBulkCopy support for JSON datatype#2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
apoorvdeshmukh merged 2 commits intodotnet:mainfromapoorvdeshmukh:dev/json-bulkcopy
Oct 16, 2024

Conversation

apoorvdeshmukh
Copy link
Contributor

This PR adds SqlBulkCopy support for for JSON datatype.
It supports streaming as well for multibyte characters.
A new testcase JsonBulkCopyTest has been introduced to test changes with CommandBehavior Default and SequentialAccess and with EnableStreaming set and unset.

@codecovCodecov
Copy link

codecovbot commentedOct 13, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is37.50000% with30 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base(2f0de19) to head(32df131).
Report is 11 commits behind head on main.

Files with missing linesPatch %Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs26.31%14 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs26.31%14 Missing⚠️
...etcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs80.00%1 Missing⚠️
.../netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs80.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2916      +/-   ##==========================================- Coverage   71.88%   71.83%   -0.05%==========================================  Files         294      294                Lines       60253    60287      +34     ==========================================- Hits        43311    43310       -1- Misses      16942    16977      +35
FlagCoverage Δ
addons92.90% <ø> (ø)
netcore75.77% <37.50%> (-0.04%)⬇️
netfx70.39% <37.50%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@saurabh500saurabh500 added this to the6.0-preview2 milestoneOct 15, 2024
@apoorvdeshmukhapoorvdeshmukh merged commitcbfa119 intodotnet:mainOct 16, 2024
130 checks passed
@mdaiglemdaigle added the Area\JsonUse this for issues that are targeted for the Json feature in the driver. labelOct 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@deepaksa1deepaksa1deepaksa1 approved these changes

@benrr101benrr101Awaiting requested review from benrr101

@saurabh500saurabh500Awaiting requested review from saurabh500

@mdaiglemdaigleAwaiting requested review from mdaigle

@samsharma2700samsharma2700Awaiting requested review from samsharma2700

Assignees
No one assigned
Labels
Area\JsonUse this for issues that are targeted for the Json feature in the driver.
Projects
None yet
Milestone
6.0-preview2
Development

Successfully merging this pull request may close these issues.

5 participants
@apoorvdeshmukh@cheenamalhotra@deepaksa1@saurabh500@mdaigle
[8]ページ先頭
©2009-2025 Movatter.jp