Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge | DbConnectionInternal (Merge Only)#2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 13 commits intodotnet:mainfrombenrr101:common-dbconnectioninternal
Oct 24, 2024

Conversation

benrr101
Copy link
Contributor

Description: This PR aims to mergeDbConnectionInternal from the netfx and netcore projects. The strategy for this merge is to move the netfx version of the class over (since it has the entire class in one file) and do a two-step merge of the two netcore files. Once combined, the bulk of the code has no differences between the netfx and netcore implementations. The only major difference is that netfx has a collection of performance counters that are updated in certain scenarios.

The commits are broken up into fairly digestible chunks that explain each step along the process. I'd recommend reviewing the PR by stepping through the commits and seeing if you agree with the changes. This version of the PR only contains the merge, no cleanup changes were made.

Testing: Most of the functional tests run locally, though I'm having some difficulty with getting all tests to work. These issues happen main branch as well, so I assume it is unrelated to the code changes.

edwardneal and Cellivar reacted with rocket emoji
Copy link
Contributor

@edwardnealedwardneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm leaving my comments here, but they should all apply to#2909 too.

The merge looks correct to me - I didn't see any logic change between the files, there are no missing/extra members. There's one logical difference between netfx and netcore though, which might be the result of a bugfix not being ported from netfx.

@codecovCodecov
Copy link

codecovbot commentedOct 11, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is76.47059% with4 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base(39c4604) to head(f75e9d4).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs75.00%4 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2910      +/-   ##==========================================- Coverage   71.92%   71.87%   -0.05%==========================================  Files         294      292       -2       Lines       60342    60100     -242     ==========================================- Hits        43398    43197     -201+ Misses      16944    16903      -41
FlagCoverage Δ
addons92.90% <ø> (ø)
netcore75.83% <73.33%> (-0.01%)⬇️
netfx70.41% <55.55%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@cheenamalhotracheenamalhotra added this to the6.0-preview2 milestoneOct 15, 2024
@benrr101benrr101 merged commitac1b3fb intodotnet:mainOct 24, 2024
124 checks passed
@benrr101benrr101 deleted the common-dbconnectioninternal branchOctober 24, 2024 21:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edwardnealedwardnealedwardneal left review comments

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@David-EngelDavid-EngelDavid-Engel approved these changes

@VladimirReshetnikovVladimirReshetnikovAwaiting requested review from VladimirReshetnikov

@saurabh500saurabh500Awaiting requested review from saurabh500

@mdaiglemdaigleAwaiting requested review from mdaigle

@samsharma2700samsharma2700Awaiting requested review from samsharma2700

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0-preview2
Development

Successfully merging this pull request may close these issues.

4 participants
@benrr101@cheenamalhotra@David-Engel@edwardneal

[8]ページ先頭

©2009-2025 Movatter.jp