NotificationsYou must be signed in to change notification settings
Fork311
Star927

Sync ref project references with runtime projects#2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mdaigle merged 2 commits intodotnet:mainfromedwardneal:sync-ref-project-dependencies

Nov 11, 2024

Merged

Sync ref project references with runtime projects#2878

mdaigle merged 2 commits intodotnet:mainfromedwardneal:sync-ref-project-dependencies

Nov 11, 2024

Conversation

Copy link

Contributor

edwardneal commentedSep 23, 2024•
edited
Loading

This PR syncs the references of the reference assemblies with those of their respective runtime assemblies. Doing so enables MSBuild's ResolveAssemblyReferences and GenerateBindingRedirects targets to generate the correct binding redirects - so if a downstream library references a later version of Azure.Core or Azure.Identity, VS will generate binding redirects so that SqlClient will use that later version.

Early testing looks promising and I think it'll resolve the issue - but for now, it just relates to#2541 and to#2082.

Synced ref project references with runtime projects

23bb77a

This should enable ResolveAssemblyReferences to generate the correct binding redirects.

edwardneal mentioned this pull request

Sep 23, 2024

Incorrect binding redirects generated for SqlClient's runtime dependencies#2541

Open

edwardneal marked this pull request as ready for review

September 23, 2024 19:18

benrr101 approved these changes

Nov 1, 2024

View reviewed changes

Copy link

Contributor

benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change seems pretty reasonable to me. Let's get the merge conflicts fixed and make sure the test runs pass and we'll get it merged. Thanks for looking into this!

benrr101 added this to the6.0-preview3 milestone

Nov 1, 2024

Merge remote-tracking branch 'upstream/main' into sync-ref-project-de…

1aa1508

…pendencies

Copy link

ContributorAuthor

edwardneal commentedNov 1, 2024

Thanks@benrr101 - just merged!

Copy link

codecovbot commentedNov 1, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base(87fa6dc) to head(1aa1508).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #2878      +/-   ##==========================================- Coverage   72.31%   72.31%   -0.01%==========================================  Files         288      288                Lines       59660    59660              ==========================================- Hits        43146    43144       -2- Misses      16514    16516       +2