Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix SqlDataReader.IsDBNull() for json#2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

deepaksa1
Copy link
Contributor

This PR aims to fixSqlDataReader.IsDBNull() API for json data type.
Currently, it returns false for a null json column. Adding the case for json type returns expected output.

@ErikEJ
Copy link
Contributor

Possible to add a test?

apoorvdeshmukh and deepaksa1 reacted with thumbs up emoji

Copy link
Contributor

@apoorvdeshmukhapoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Please add a testcase that fails without your fix.

deepaksa1 reacted with thumbs up emoji
Copy link
Contributor

@apoorvdeshmukhapoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested few minor changes.

@deepaksa1deepaksa1 merged commitf5994c8 intodotnet:feat-jsonsupportSep 4, 2024
8 checks passed
@deepaksa1deepaksa1 deleted the dev/jsonNullFix branchSeptember 4, 2024 09:46
deepaksa1 added a commit to deepaksa1/SqlClient that referenced this pull requestOct 1, 2024
* fix SqlDataReader.IsDBNull() for json* add testcase* resolve PR commits
@mdaiglemdaigle added this to the6.0-preview2 milestoneOct 24, 2024
@David-EngelDavid-Engel added the Area\JsonUse this for issues that are targeted for the Json feature in the driver. labelNov 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rojirojiroji left review comments

@saurabh500saurabh500saurabh500 approved these changes

@apoorvdeshmukhapoorvdeshmukhapoorvdeshmukh approved these changes

Assignees
No one assigned
Labels
Area\JsonUse this for issues that are targeted for the Json feature in the driver.
Projects
None yet
Milestone
6.0-preview2
Development

Successfully merging this pull request may close these issues.

7 participants
@deepaksa1@ErikEJ@saurabh500@roji@apoorvdeshmukh@mdaigle@David-Engel
[8]ページ先頭
©2009-2025 Movatter.jp