Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Transient fault handling issue with OpenAsync#1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotracheenamalhotra commentedApr 5, 2023•
edited
Loading

Addresses#1982

'Retry', is a completion callback that is completed afterCreateConnection() completes (which handles transient faults), here:

if(caughtException!=null)
{
next.Completion.TrySetException(caughtException);
}
elseif(timeout)
{
next.Completion.TrySetException(ADP.ExceptionWithStackTrace(ADP.PooledOpenTimeout()));
}
else
{
Debug.Assert(connection!=null,"connection should never be null in success case");
if(!next.Completion.TrySetResult(connection))
{
// if the completion was cancelled, lets try and get this connection back for the next try
PutObject(connection,next.Owner);
}
}

So I don't see a reason to not enable transient fault handling retries when its specified.

lcheunglci reacted with thumbs up emoji
@codecov
Copy link

codecovbot commentedApr 5, 2023•
edited
Loading

Codecov Report

Patch coverage:100.00% and project coverage change:-0.07⚠️

Comparison is base(a5ad838) 70.59% compared to head(80c4096) 70.52%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #1983      +/-   ##==========================================- Coverage   70.59%   70.52%   -0.07%==========================================  Files         306      306                Lines       61667    61725      +58     ==========================================- Hits        43533    43532       -1- Misses      18134    18193      +59
FlagCoverage Δ
addons92.88% <ø> (ø)
netcore73.23% <100.00%> (-0.17%)⬇️
netfx69.17% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs78.86% <100.00%> (-0.36%)⬇️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs59.42% <100.00%> (ø)

... and16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment?Let us know in this issue.

@David-Engel
Copy link
Contributor

Nice. Thanks!

Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@JRahnamaJRahnama added this to the5.2.0-preview1 milestoneApr 19, 2023
@Kaur-ParminderKaur-Parminder merged commit4a91443 intodotnet:mainApr 19, 2023
@cheenamalhotracheenamalhotra deleted the fix-openAsync-retry branchApril 20, 2023 07:15
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull requestJun 29, 2023
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull requestOct 25, 2023
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull requestMay 16, 2024
…ing issue with OpenAsync (dotnet#1983)"This reverts commit80d1f47.# Conflicts:#src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull requestMay 16, 2024
…ing issue with OpenAsync (dotnet#1983)"This reverts commit80d1f47.# Conflicts:#src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull requestMay 16, 2024
DavoudEshtehari added a commit that referenced this pull requestMay 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JRahnamaJRahnamaJRahnama approved these changes

@DavoudEshtehariDavoudEshtehariDavoudEshtehari approved these changes

@David-EngelDavid-EngelAwaiting requested review from David-Engel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0-preview1
Development

Successfully merging this pull request may close these issues.

Transient Fault Handling is disabled by default with SqlConnection.OpenAsync()
5 participants
@cheenamalhotra@David-Engel@JRahnama@DavoudEshtehari@Kaur-Parminder
[8]ページ先頭
©2009-2025 Movatter.jp