Commit21e10ae

committed

Regression | Revert PR#2281 SNIProxy code change (#2395)

1 parentfaf9b95 commit21e10aeCopy full SHA for 21e10ae

File tree

-3

lines changed

src/Microsoft.Data.SqlClient
- netcore/src/Microsoft/Data/SqlClient/SNI
  - SNIProxy.cs
- tests/ManualTests/SQL/InstanceNameTest
  - InstanceNameTest.cs

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -653,10 +653,10 @@ private bool InferConnectionDetails()`
`653`	`653`
`654`	`654`	`Port=port;`
`655`	`655`	`}`
`656`		`-// Instance Name Handling.`
`657`		`-if(backSlashIndex>-1)`
	`656`	`+// Instance Name Handling.Only if we found a '\' and we did not find a port in the Data Source`
	`657`	`+elseif(backSlashIndex>-1)`
`658`	`658`	`{`
`659`		`-// This means that thereis apart separated by'\'`
	`659`	`+// This means that therewill not be anypart separated bycomma.`
`660`	`660`	`InstanceName=tokensByCommaAndSlash[1].Trim();`
`661`	`661`
`662`	`662`	`if(string.IsNullOrWhiteSpace(InstanceName))`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ public static void ConnectManagedWithInstanceNameTest(bool useMultiSubnetFailove`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`#ifNETCOREAPP`
	`90`	`+[ActiveIssue("27824")]// When specifying instance name and port number, this method call always returns false`
`90`	`91`	`[ConditionalFact(nameof(IsSPNPortNumberTestForTCP))]`
`91`	`92`	`publicstaticvoidPortNumberInSPNTestForTCP()`
`92`	`93`	`{`

Comments

(0)